Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 5f01d311aa0eda2f0a89d49f976a68dbf2ee239b..caa41d061ce1ee2c170110052f6f7e84f1a3f520 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -94,7 +94,18 @@ class PasswordManagerClient {
// that was overidden.
virtual bool PromptUserToSaveOrUpdatePassword(
std::unique_ptr<PasswordFormManager> form_to_save,
- bool update_password) = 0;
+ bool is_update) = 0;
+
+ // Informs the embedder that the user started typing a password and a password
+ // prompt should be available on click on the omnibox icon.
+ virtual void ShowManualFallbackForSaving(
+ std::unique_ptr<PasswordFormManager> form_to_save,
+ bool has_generated_password,
+ bool is_update) = 0;
+
+ // Informs the embedder that the user cleared the password field and the
+ // fallback for password saving should be not available.
+ virtual void HideManualFallbackForSaving() = 0;
// Informs the embedder of a password forms that the user should choose from.
// Returns true if the prompt is indeed displayed. If the prompt is not

Powered by Google App Engine
This is Rietveld 408576698