Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: chrome/browser/ui/passwords/passwords_client_ui_delegate.h

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/passwords_client_ui_delegate.h
diff --git a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
index b2b5928a8c88f272fe721ce341004f897a2e9963..65d3624de78f11148c5bb2fd2e2885d85780b1b3 100644
--- a/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
+++ b/chrome/browser/ui/passwords/passwords_client_ui_delegate.h
@@ -38,6 +38,18 @@ class PasswordsClientUIDelegate {
virtual void OnUpdatePasswordSubmitted(
std::unique_ptr<password_manager::PasswordFormManager> form_manager) = 0;
+ // Called when the user starts typing in a password field. This switches the
+ // icon to a pending state, a user can click on the icon and open a
+ // save/update bubble.
+ virtual void OnShowManualFallbackForSaving(
+ std::unique_ptr<password_manager::PasswordFormManager> form_manager,
+ bool has_generated_password,
+ bool is_update) = 0;
+
+ // Called when the user cleared the password field. This switches the icon
+ // back to manage or inactive state.
+ virtual void OnHideManualFallbackForSaving() = 0;
+
// Called when the site asks user to choose from credentials. This triggers
// the UI to prompt the user. |local_credentials| shouldn't be empty. |origin|
// is a URL of the site that requested a credential.

Powered by Google App Engine
This is Rietveld 408576698