Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6550)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2915763003: [Password Manager] Show omnibox icon and anchored prompt once user start typing password (Closed)
Patch Set: Rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index 6ef8efa9463e80cf8cc80a17696e21889dadbcb4..b619464a8390e3b221d1ae18211c431863d1b930 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -94,6 +94,32 @@ void ManagePasswordsUIController::OnUpdatePasswordSubmitted(
UpdateBubbleAndIconVisibility();
}
+void ManagePasswordsUIController::OnShowManualFallbackForSaving(
+ std::unique_ptr<PasswordFormManager> form_manager,
+ bool has_generated_password,
+ bool is_update) {
+ DestroyAccountChooser();
+ if (has_generated_password)
+ passwords_data_.OnAutomaticPasswordSave(std::move(form_manager));
+ else if (is_update)
+ passwords_data_.OnUpdatePassword(std::move(form_manager));
+ else
+ passwords_data_.OnPendingPassword(std::move(form_manager));
+ UpdateBubbleAndIconVisibility();
+}
+
+void ManagePasswordsUIController::OnHideManualFallbackForSaving() {
+ if (passwords_data_.state() != password_manager::ui::PENDING_PASSWORD_STATE &&
+ passwords_data_.state() !=
+ password_manager::ui::PENDING_PASSWORD_UPDATE_STATE &&
+ passwords_data_.state() != password_manager::ui::CONFIRMATION_STATE) {
+ return;
+ }
+
+ passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
+ UpdateBubbleAndIconVisibility();
+}
+
bool ManagePasswordsUIController::OnChooseCredentials(
std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials,
const GURL& origin,

Powered by Google App Engine
This is Rietveld 408576698