[Password Manager] Show omnibox icon and anchored prompt once user start typing password

chrome/browser/password_manager/credential_manager_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/password_manager/password_manager_test_base.h"
@@ skipping 139 matching lines @@
     // context of the old URL, |a_url|.
     //
     // The CredentialManager Mojo interface is Channel-associated, so message
     // ordering with legacy IPC messages is preserved. Therefore, servicing the
     // store() called from the `unload` handler, triggered from
     // FrameLoader::PrepareForCommit, will be serviced before
     // FrameHostMsg_DidCommitProvisionalLoad, thus before DidFinishNavigation,
     ASSERT_TRUE(client->was_store_ever_called());
 
     BubbleObserver prompt_observer(WebContents());
-    prompt_observer.WaitForSavePrompt();
-    ASSERT_TRUE(prompt_observer.IsShowingSavePrompt());
+    prompt_observer.WaitForAutomaticSavePrompt();
+    ASSERT_TRUE(prompt_observer.IsSavePromptShownAutomatically());
     prompt_observer.AcceptSavePrompt();
 
     WaitForPasswordStore();
 
     password_manager::TestPasswordStore* test_password_store =
         static_cast<password_manager::TestPasswordStore*>(
             PasswordStoreFactory::GetForProfile(
                 browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
                 .get());
 
@@ skipping 151 matching lines @@
           password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD);
 
   NavigationObserver observer(WebContents());
   observer.SetPathToWaitFor("/password/done.html");
   observer.Wait();
 
   // Wait for the password store before checking the prompt because it pops up
   // after the store replies.
   WaitForPasswordStore();
   BubbleObserver prompt_observer(WebContents());
-  EXPECT_FALSE(prompt_observer.IsShowingSavePrompt());
-  EXPECT_FALSE(prompt_observer.IsShowingUpdatePrompt());
+  EXPECT_FALSE(prompt_observer.IsSavePromptShownAutomatically());
+  EXPECT_FALSE(prompt_observer.IsUpdatePromptShownAutomatically());
 
   // There should be an entry for both psl.example.com and www.example.com.
   password_manager::TestPasswordStore::PasswordMap passwords =
       password_store->stored_passwords();
   GURL www_url = https_test_server().GetURL("www.example.com", "/");
   EXPECT_EQ(2U, passwords.size());
   EXPECT_TRUE(base::ContainsKey(passwords, psl_url.spec()));
   EXPECT_TRUE(base::ContainsKey(passwords, www_url.spec()));
 }
 
@@ skipping 70 matching lines @@
       "navigator.credentials.get({password: true})"
       ".then(cred => window.location = '/password/done.html');"));
 
   NavigationObserver observer(WebContents());
   observer.SetPathToWaitFor("/password/done.html");
   observer.Wait();
 
   BubbleObserver prompt_observer(WebContents());
   // The autofill password manager shouldn't react to the successful login
   // because it was suppressed when the site got the credential back.
-  EXPECT_FALSE(prompt_observer.IsShowingSavePrompt());
+  EXPECT_FALSE(prompt_observer.IsSavePromptShownAutomatically());
 }
 
 // Regression test for https://crbug.com/736357.
 IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,
                        StoreInUnloadHandler_SameSite_OnDemandMojoPipe) {
   TestStoreInUnloadHandlerForSameSiteNavigation(
       false /* preestablish_mojo_pipe */);
 }
 
 // Regression test for https://crbug.com/736357.
@@ skipping 37 matching lines @@
   // Store a credential, and expect it to establish the Mojo connection.
   EXPECT_FALSE(client->has_binding_for_credential_manager());
   EXPECT_FALSE(client->was_store_ever_called());
 
   ASSERT_TRUE(content::ExecuteScript(
       WebContents(),
       "var c = new PasswordCredential({ id: 'user', password: 'hunter2' });"
       "navigator.credentials.store(c);"));
 
   BubbleObserver prompt_observer(WebContents());
-  prompt_observer.WaitForSavePrompt();
-  ASSERT_TRUE(prompt_observer.IsShowingSavePrompt());
+  prompt_observer.WaitForAutomaticSavePrompt();
+  ASSERT_TRUE(prompt_observer.IsSavePromptShownAutomatically());
   prompt_observer.AcceptSavePrompt();
   WaitForPasswordStore();
 
   EXPECT_TRUE(client->has_binding_for_credential_manager());
   EXPECT_TRUE(client->was_store_ever_called());
 
   // Trigger a same-site navigation.
   content::RenderFrameHost* old_rfh = WebContents()->GetMainFrame();
   ui_test_utils::NavigateToURL(browser(), a_url2);
   ASSERT_EQ(old_rfh, WebContents()->GetMainFrame());
@@ skipping 45 matching lines @@
   NavigationObserver form_submit_observer(WebContents());
   ASSERT_TRUE(content::ExecuteScript(
       RenderViewHost(),
       "document.getElementById('username_field').value = 'user';"
       "document.getElementById('password_field').value = 'autofill';"
       "document.getElementById('input_submit_button').click();"));
   form_submit_observer.Wait();
 
   WaitForPasswordStore();
   BubbleObserver prompt_observer(WebContents());
-  ASSERT_TRUE(prompt_observer.IsShowingSavePrompt());
+  ASSERT_TRUE(prompt_observer.IsSavePromptShownAutomatically());
   prompt_observer.AcceptSavePrompt();
 
   WaitForPasswordStore();
   password_manager::TestPasswordStore::PasswordMap stored =
       static_cast<password_manager::TestPasswordStore*>(
           PasswordStoreFactory::GetForProfile(
               browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
               .get())->stored_passwords();
   ASSERT_EQ(1u, stored.size());
   autofill::PasswordForm signin_form = stored.begin()->second[0];
@@ skipping 37 matching lines @@
       RenderViewHost(),
       "document.getElementById('username_field').value = 'user';"
       "document.getElementById('password_field').value = 'autofill';"
       "document.getElementById('input_submit_button').click();"));
   form_submit_observer.Wait();
 
   // Wait for the password store before checking the prompt because it pops up
   // after the store replies.
   WaitForPasswordStore();
   BubbleObserver prompt_observer(WebContents());
-  EXPECT_FALSE(prompt_observer.IsShowingSavePrompt());
-  EXPECT_FALSE(prompt_observer.IsShowingUpdatePrompt());
+  EXPECT_FALSE(prompt_observer.IsSavePromptShownAutomatically());
+  EXPECT_FALSE(prompt_observer.IsUpdatePromptShownAutomatically());
   signin_form.skip_zero_click = false;
   signin_form.times_used = 1;
   signin_form.password_value = base::ASCIIToUTF16("API");
   password_manager::TestPasswordStore::PasswordMap stored =
       password_store->stored_passwords();
   ASSERT_EQ(1u, stored.size());
   EXPECT_EQ(signin_form, stored[signin_form.signon_realm][0]);
 }
 
 IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest, CredentialsAutofilled) {
   NavigateToFile("/password/password_form.html");
 
   ASSERT_TRUE(content::ExecuteScript(
       RenderFrameHost(),
       "var c = new PasswordCredential({ id: 'user', password: '12345' });"
       "navigator.credentials.store(c);"));
   BubbleObserver bubble_observer(WebContents());
-  bubble_observer.WaitForSavePrompt();
+  bubble_observer.WaitForAutomaticSavePrompt();
   bubble_observer.AcceptSavePrompt();
 
   // Reload the page and make sure it's autofilled.
   NavigateToFile("/password/password_form.html");
   WaitForElementValue("username_field", "user");
   content::SimulateMouseClickAt(
       WebContents(), 0, blink::WebMouseEvent::Button::kLeft, gfx::Point(1, 1));
   WaitForElementValue("password_field", "12345");
 }
 
 }  // namespace