Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2911873002: Generate methods for text-indent properties in ComputedStyleBase. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate methods for text-indent properties in ComputedStyleBase. This patch generates getters/setters/mapping for TextIndent, TextIndentLine, TextIndentType. Diff of generated files: https://gist.github.com/218a9decdab88fe8ca06b0222b1fe5ff/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2911873002 Cr-Commit-Position: refs/heads/master@{#475491} Committed: https://chromium.googlesource.com/chromium/src/+/8ec54cc76d19e49895fb195b71db7dabf3c6a3d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -37 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (16 generated)
shend
Hi Eddy, PTAL
3 years, 6 months ago (2017-05-29 01:49:00 UTC) #4
rune
lgtm
3 years, 6 months ago (2017-05-29 09:34:31 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2904383002 Patch 1). Please resolve the dependency and ...
3 years, 6 months ago (2017-05-29 22:45:15 UTC) #12
meade_UTC10
lgtm
3 years, 6 months ago (2017-05-30 03:50:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911873002/1
3 years, 6 months ago (2017-05-30 10:56:37 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 11:28:17 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ec54cc76d19e49895fb195b71db...

Powered by Google App Engine
This is Rietveld 408576698