Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: chrome/browser/ui/views/payments/editor_view_controller.cc

Issue 2910153002: Remove views::Label::SetDisabledColor(). Replace with typography colors. (Closed)
Patch Set: rebase for r476345 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/editor_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/editor_view_controller.cc b/chrome/browser/ui/views/payments/editor_view_controller.cc
index 1eacd6c0a57a9e83024c53f6ac30b5e56afa356f..40b4fc8981bc3fbefe945af24c90333e35ad4dcd 100644
--- a/chrome/browser/ui/views/payments/editor_view_controller.cc
+++ b/chrome/browser/ui/views/payments/editor_view_controller.cc
@@ -325,20 +325,16 @@ std::unique_ptr<views::View> EditorViewController::CreateEditorView() {
// Validate all fields and disable the primary (Done) button if necessary.
primary_button()->SetEnabled(ValidateInputFields());
- // Adds the "* indicates a required field" label in "disabled" grey text.
- std::unique_ptr<views::Label> required_field = base::MakeUnique<views::Label>(
- l10n_util::GetStringUTF16(IDS_PAYMENTS_REQUIRED_FIELD_MESSAGE));
- required_field->SetDisabledColor(
- required_field->GetNativeTheme()->GetSystemColor(
- ui::NativeTheme::kColorId_LabelDisabledColor));
- required_field->SetEnabled(false);
-
views::ColumnSet* required_field_columns = editor_layout->AddColumnSet(2);
required_field_columns->AddColumn(views::GridLayout::LEADING,
views::GridLayout::CENTER, 1,
views::GridLayout::USE_PREF, 0, 0);
editor_layout->StartRow(0, 2);
- editor_layout->AddView(required_field.release());
+ // Adds the "* indicates a required field" label in "hint" grey text.
+ editor_layout->AddView(
+ CreateHintLabel(
+ l10n_util::GetStringUTF16(IDS_PAYMENTS_REQUIRED_FIELD_MESSAGE))
+ .release());
editor_view->SetLayoutManager(editor_layout.release());

Powered by Google App Engine
This is Rietveld 408576698