Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2909233002:
Generate getters/setters for TextSizeAdjust. (Closed)
DescriptionGenerate getters/setters for TextSizeAdjust.
Currently, the TextSizeAdjust property is a 'storage_only' field, so
it has no generated public getters/setters. This patch changes it to an
'external' field so that its getters/setters can be generated as well.
Diff: https://gist.github.com/nainar/649eeb3c1dc02dc231fb5f9a75da44ac/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2909233002
Cr-Commit-Position: refs/heads/master@{#475494}
Committed: https://chromium.googlesource.com/chromium/src/+/f0b43318558028fe42bc12bf1d1096849d205455
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 30 (20 generated)
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
nainar@chromium.org changed reviewers: + shend@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Generate getters/setters for TextSizeAdjust. Currently, the TextSizeAdjust property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that its getters/setters can be generated as well. BUG=628043 ========== to ========== Generate getters/setters for TextSizeAdjust. Currently, the TextSizeAdjust property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that its getters/setters can be generated as well. Diff: https://gist.github.com/nainar/649eeb3c1dc02dc231fb5f9a75da44ac/revisions BUG=628043 ==========
lgtm
nainar@chromium.org changed reviewers: + dstockwell@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
rune@opera.com changed reviewers: + rune@opera.com
rs lgtm
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nainar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org, rune@opera.com Link to the patchset: https://codereview.chromium.org/2909233002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496141344747420,
"parent_rev": "f003932c6720ec1b62d30928d25ebc6bd9c73de9", "commit_rev":
"f0b43318558028fe42bc12bf1d1096849d205455"}
Message was sent while issue was closed.
Description was changed from ========== Generate getters/setters for TextSizeAdjust. Currently, the TextSizeAdjust property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that its getters/setters can be generated as well. Diff: https://gist.github.com/nainar/649eeb3c1dc02dc231fb5f9a75da44ac/revisions BUG=628043 ========== to ========== Generate getters/setters for TextSizeAdjust. Currently, the TextSizeAdjust property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that its getters/setters can be generated as well. Diff: https://gist.github.com/nainar/649eeb3c1dc02dc231fb5f9a75da44ac/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2909233002 Cr-Commit-Position: refs/heads/master@{#475494} Committed: https://chromium.googlesource.com/chromium/src/+/f0b43318558028fe42bc12bf1d10... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f0b43318558028fe42bc12bf1d10... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
