Source/core/inspector/InspectorDebuggerAgent.h - Issue 290633009: DevTools: Show detailed information for exceptions during snippet execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.h

Issue 290633009: DevTools: Show detailed information for exceptions during snippet execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html ('K') | « Source/bindings/v8/ScriptDebugServer.cpp ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDebuggerAgent.h

diff --git a/Source/core/inspector/InspectorDebuggerAgent.h b/Source/core/inspector/InspectorDebuggerAgent.h

index 9b1b6ac8eccebede60e7c22e642d9ab3b21cd0f0..d621628a9011b3e351d3c68caa41893a91d36266 100644

--- a/Source/core/inspector/InspectorDebuggerAgent.h

+++ b/Source/core/inspector/InspectorDebuggerAgent.h

@@ -133,8 +133,8 @@ public:

const bool* generatePreview,

RefPtr<TypeBuilder::Runtime::RemoteObject>& result,

TypeBuilder::OptOutput<bool>* wasThrown) OVERRIDE FINAL;

- virtual void compileScript(ErrorString*, const String& expression, const String& sourceURL, const int* executionContextId, TypeBuilder::OptOutput<TypeBuilder::Debugger::ScriptId>*, TypeBuilder::OptOutput<String>* syntaxErrorMessage, TypeBuilder::OptOutput<int>* lineNumber, TypeBuilder::OptOutput<int>* columnNumber) OVERRIDE;

- virtual void runScript(ErrorString*, const TypeBuilder::Debugger::ScriptId&, const int* executionContextId, const String* objectGroup, const bool* doNotPauseOnExceptionsAndMuteConsole, RefPtr<TypeBuilder::Runtime::RemoteObject>& result, TypeBuilder::OptOutput<bool>* wasThrown, TypeBuilder::OptOutput<int>* lineNumber, TypeBuilder::OptOutput<int>* columnNumber) OVERRIDE;

+ virtual void compileScript(ErrorString*, const String& expression, const String& sourceURL, const int* executionContextId, TypeBuilder::OptOutput<TypeBuilder::Debugger::ScriptId>*, RefPtr<TypeBuilder::Debugger::ExceptionDetails>&) OVERRIDE;

+ virtual void runScript(ErrorString*, const TypeBuilder::Debugger::ScriptId&, const int* executionContextId, const String* objectGroup, const bool* doNotPauseOnExceptionsAndMuteConsole, RefPtr<TypeBuilder::Runtime::RemoteObject>& result, RefPtr<TypeBuilder::Debugger::ExceptionDetails>&) OVERRIDE;

virtual void setOverlayMessage(ErrorString*, const String*) OVERRIDE;

virtual void setVariableValue(ErrorString*, int in_scopeNumber, const String& in_variableName, const RefPtr<JSONObject>& in_newValue, const String* in_callFrame, const String* in_functionObjectId) OVERRIDE FINAL;

virtual void skipStackFrames(ErrorString*, const String* pattern) OVERRIDE FINAL;