Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/browser/ui/views/try_chrome_dialog.h

Issue 2904823002: Inactive toast ux changes (Closed)
Patch Set: move run_loop_ to a unique_ptr Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TRY_CHROME_DIALOG_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TRY_CHROME_DIALOG_H_
6 #define CHROME_BROWSER_UI_VIEWS_TRY_CHROME_DIALOG_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TRY_CHROME_DIALOG_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/run_loop.h"
13 #include "base/time/time.h"
14 #include "chrome/browser/ui/startup/startup_browser_creator.h"
15 #include "chrome/installer/util/experiment_storage.h"
12 #include "ui/gfx/geometry/rect.h" 16 #include "ui/gfx/geometry/rect.h"
13 #include "ui/gfx/geometry/size.h" 17 #include "ui/gfx/geometry/size.h"
14 #include "ui/gfx/native_widget_types.h" 18 #include "ui/gfx/native_widget_types.h"
15 #include "ui/views/controls/button/button.h" 19 #include "ui/views/controls/button/button.h"
16 #include "ui/views/controls/link_listener.h"
17 20
18 namespace views { 21 namespace views {
19 class RadioButton;
20 class Checkbox;
21 class Widget; 22 class Widget;
22 } 23 }
23 24
24 // This class displays a modal dialog using the views system. The dialog asks 25 // This class displays a modal dialog using the views system. The dialog asks
25 // the user to give chrome another try. This class only handles the UI so the 26 // the user to give Chrome another try. This class only handles the UI so the
26 // resulting actions are up to the caller. One flavor looks like this: 27 // resulting actions are up to the caller.
28 //
29 // The layout is as follows:
27 // 30 //
28 // +-----------------------------------------------+ 31 // +-----------------------------------------------+
29 // | |icon| There is a new, safer version [x] | 32 // | |icon| Header text. [x] |
30 // | |icon| of Google Chrome available | 33 // | |
31 // | [o] Try it out (already installed) | 34 // | Body text. |
32 // | [ ] Uninstall Google Chrome | 35 // | [ Open Chrome ] [No Thanks] |
33 // | [ OK ] [Don't bug me] |
34 // | _why_am_I_seeing this?_ |
35 // +-----------------------------------------------+ 36 // +-----------------------------------------------+
36 // 37 //
37 // Another flavor looks like: 38 // Some variants do not have body text, or only have one button.
38 // +-----------------------------------------------+ 39 class TryChromeDialog : public views::ButtonListener {
39 // | |icon| There is a new, safer version [x] |
40 // | |icon| of Google Chrome available |
41 // | [o] Try it out (already installed) |
42 // | [ ] Don't bug me |
43 // | [ OK ] |
44 // +-----------------------------------------------+
45 //
46 // And the 2013 version looks like:
47 // +-----------------------------------------------+
48 // | |icon| There is a new version of [x] |
49 // | |icon| Google Chrome available |
50 // | [o] Try it out (already installed) |
51 // | [ ] Don't bug me |
52 // | --------------------------------------------- |
53 // | [x] Make it the default browser [ OK ] |
54 // +-----------------------------------------------+
55
56 class TryChromeDialogView : public views::ButtonListener,
57 public views::LinkListener {
58 public: 40 public:
59 // Receives a handle to the active modal dialog, or NULL when the active 41 // Receives a handle to the active modal dialog, or NULL when the active
60 // dialog is dismissed. 42 // dialog is dismissed.
61 typedef base::Callback<void(gfx::NativeWindow active_dialog)> 43 typedef base::Callback<void(gfx::NativeWindow active_dialog)>
62 ActiveModalDialogListener; 44 ActiveModalDialogListener;
63 45
64 enum Result { 46 enum Result {
65 TRY_CHROME, // Launch chrome right now. 47 NOT_NOW, // Don't launch chrome. Exit now.
66 TRY_CHROME_AS_DEFAULT, // Launch chrome and make it the default. 48 OPEN_CHROME_WELCOME, // Launch Chrome to the standard Welcome page.
67 NOT_NOW, // Don't launch chrome. Exit now. 49 OPEN_CHROME_WELCOME_WIN10, // Launch Chrome to the Win10 Welcome page.
68 UNINSTALL_CHROME, // Initiate chrome uninstall and exit. 50 OPEN_CHROME_DEFAULT, // Launch Chrome to the default page.
69 DIALOG_ERROR, // An error occurred creating the dialog.
70 COUNT
71 }; 51 };
72 52
73 // Shows a modal dialog asking the user to give chrome another try. See 53 // Shows a modal dialog asking the user to give Chrome another try. See
74 // above for the possible outcomes of the function. This is an experimental, 54 // above for the possible outcomes of the function.
75 // non-localized dialog. 55 // |group| selects what strings to present and what controls are shown.
76 // |flavor| can be 0, 1, 2 or 3 and selects what strings to present.
77 // |listener| will be notified when the dialog becomes active and when it is 56 // |listener| will be notified when the dialog becomes active and when it is
78 // dismissed. 57 // dismissed.
79 // Note that the dialog has no parent and it will position itself in a lower 58 // Note that the dialog has no parent and it will position itself in a lower
80 // corner of the screen. The dialog does not steal focus and does not have an 59 // corner of the screen or near the Chrome taskbar button.
81 // entry in the taskbar. 60 // The dialog does not steal focus and does not have an entry in the taskbar.
82 static Result Show(size_t flavor, 61 static Result Show(size_t group, const ActiveModalDialogListener& listener);
83 const ActiveModalDialogListener& listener); 62
84 private: 63 private:
85 // Indicates whether the dialog is modal 64 // Indicates whether the dialog is modal
86 enum class kDialogType { 65 enum class DialogType {
87 MODAL, // Modal dialog. 66 MODAL, // Modal dialog.
88 MODELESS, // Modeless dialog. 67 MODELESS_FOR_TEST, // Modeless dialog.
89 }; 68 };
90 69
91 // Indicates the usage type. Chrome or tests. 70 // Indicates the usage type. Chrome or tests.
92 enum class kUsageType { 71 enum class UsageType {
93 FOR_CHROME, 72 FOR_CHROME,
94 FOR_TESTING, 73 FOR_TESTING,
95 }; 74 };
96 75
97 friend class TryChromeDialogTest; 76 friend class TryChromeDialogTest;
98 77
99 explicit TryChromeDialogView(size_t flavor); 78 // Creates a Try Chrome toast dialog. |group| signifies an experiment group
100 ~TryChromeDialogView() override; 79 // which dictactes messaging text and presence of ui elements.
80 explicit TryChromeDialog(size_t group);
81 ~TryChromeDialog() override;
101 82
102 // Helper function to show the dialog. 83 // Helper function to show the dialog.
103 // The |dialog_type| parameter indicates whether the dialog is modal. 84 // The |dialog_type| parameter indicates whether the dialog is modal.
85 // Note that modeless invocation returns before the user has made a
86 // selection, and is used in testing. This case will always return NOT_NOW.
104 // The |usage_type| parameter indicates whether this is being invoked by 87 // The |usage_type| parameter indicates whether this is being invoked by
105 // chrome or a test. 88 // Chrome or a test.
106 Result ShowDialog(const ActiveModalDialogListener& listener, 89 Result ShowDialog(const ActiveModalDialogListener& listener,
107 kDialogType dialog_type, 90 DialogType dialog_type,
108 kUsageType usage_type); 91 UsageType usage_type);
109 92
110 // Returns a screen rectangle that is fit to show the window. In particular 93 // Returns a screen rectangle that is fit to show the window. In particular
111 // it has the following properties: a) is visible and b) is attached to the 94 // it has the following properties: a) is visible and b) is attached to the
112 // bottom of the working area. For LTR machines it returns a left side 95 // bottom of the working area. For LTR machines it returns a left side
113 // rectangle and for RTL it returns a right side rectangle so that the dialog 96 // rectangle and for RTL it returns a right side rectangle so that the dialog
114 // does not compete with the standard place of the start menu. 97 // does not compete with the standard place of the start menu.
115 gfx::Rect ComputeWindowPosition(const gfx::Size& size, bool is_RTL); 98 gfx::Rect ComputePopupBounds(const gfx::Size& size, bool is_RTL);
116
117 // Create a windows region that looks like a toast of width |w| and height
118 // |h|. This is best effort, so we don't care much if the operation fails.
119 void SetToastRegion(HWND window, int w, int h);
120 99
121 // views::ButtonListener: 100 // views::ButtonListener:
122 // We have two buttons and according to what the user clicked we set |result_| 101 // We have two buttons and according to what the user clicked we set |result_|
123 // and we should always close and end the modal loop. 102 // and we should always close and end the modal loop.
124 void ButtonPressed(views::Button* sender, const ui::Event& event) override; 103 void ButtonPressed(views::Button* sender, const ui::Event& event) override;
125 104
126 // views::LinkListener: 105 // Controls whether we're running in testing config.
127 // If the user selects the link we need to fire off the default browser that 106 // Experiment metrics setting is disabled in tests.
128 // by some convoluted logic should not be chrome. 107 UsageType usage_type_;
129 void LinkClicked(views::Link* source, int event_flags) override;
130 108
131 // Controls which flavor of the heading text to use. 109 // Controls which experiment group to use for varying the layout and controls.
132 size_t flavor_; 110 const size_t group_;
133 111
134 // We don't own any of these pointers. The |popup_| owns itself and owns the 112 // Time when the toast was displayed.
135 // other views. 113 base::TimeTicks time_shown_;
114
115 // Unowned; |popup_| owns itself.
136 views::Widget* popup_; 116 views::Widget* popup_;
137 views::RadioButton* try_chrome_; 117
138 views::RadioButton* kill_chrome_; 118 // RunLoop to run the dialog before the main message loop.
139 views::RadioButton* dont_try_chrome_; 119 std::unique_ptr<base::RunLoop> run_loop_;
140 views::Checkbox* make_default_; 120
121 // Experiment feedback interface.
122 installer::ExperimentStorage storage_;
123
124 // Result of displaying the dialog: accepted, dismissed, etc.
141 Result result_; 125 Result result_;
142 126
143 DISALLOW_COPY_AND_ASSIGN(TryChromeDialogView); 127 DISALLOW_COPY_AND_ASSIGN(TryChromeDialog);
144 }; 128 };
145 129
146 #endif // CHROME_BROWSER_UI_VIEWS_TRY_CHROME_DIALOG_VIEW_H_ 130 #endif // CHROME_BROWSER_UI_VIEWS_TRY_CHROME_DIALOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698