Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller_unittest.mm

Issue 2904053002: [ios] Active web state observer in tab collection. (Closed)
Patch Set: Update unittest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller_unittest.mm
diff --git a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller_unittest.mm b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller_unittest.mm
index 7d61f0ad4ddb00843428b6234df5c5781340987e..f6b5cf8557983ca8e50575468d597e86b61a5208 100644
--- a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller_unittest.mm
+++ b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller_unittest.mm
@@ -40,19 +40,21 @@ class TabCollectionViewControllerTest : public PlatformTest {
// Tests that an item is inserted.
TEST_F(TabCollectionViewControllerTest, TestInsertItem) {
- [view_controller_ insertItem:[[TabCollectionItem alloc] init] atIndex:0];
+ [view_controller_ insertItem:[[TabCollectionItem alloc] init]
+ atIndex:0
+ selectedIndex:0];
EXPECT_EQ(3, static_cast<int>(view_controller_.items.count));
}
// Tests that an item is deleted.
TEST_F(TabCollectionViewControllerTest, TestDeleteItem) {
- [view_controller_ deleteItemAtIndex:0];
+ [view_controller_ deleteItemAtIndex:0 selectedIndex:0];
EXPECT_EQ(1, static_cast<int>(view_controller_.items.count));
}
// Tests that an item is moved.
TEST_F(TabCollectionViewControllerTest, TestMoveItem) {
- [view_controller_ moveItemFromIndex:0 toIndex:1];
+ [view_controller_ moveItemFromIndex:0 toIndex:1 selectedIndex:0];
EXPECT_NSEQ(@"Item1", view_controller_.items[0].title);
}
@@ -68,6 +70,6 @@ TEST_F(TabCollectionViewControllerTest, TestReplaceItem) {
TEST_F(TabCollectionViewControllerTest, TestInitializeItems) {
TabCollectionItem* item = [[TabCollectionItem alloc] init];
item.title = @"NewItem";
- [view_controller_ populateItems:@[ item ]];
+ [view_controller_ populateItems:@[ item ] selectedIndex:0];
EXPECT_NSEQ(@"NewItem", view_controller_.items[0].title);
}

Powered by Google App Engine
This is Rietveld 408576698