ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm - Issue 2904053002: [ios] Active web state observer in tab collection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

Issue 2904053002: [ios] Active web state observer in tab collection. (Closed)

Patch Set: Update unittest Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

diff --git a/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm b/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

index 4f1be95a138fbede477a10838c6df09292275a00..2bc0022405217b032abcd9a24dff53a3b4fa5290 100644

--- a/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

+++ b/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

@@ -72,9 +72,11 @@

- (void)stopFinding {

web::WebState* webState = self.webStateList->GetActiveWebState();

- FindTabHelper* helper = FindTabHelper::FromWebState(webState);

- DCHECK(helper);

- helper->StopFinding(nil);

+ if (webState) {

+ FindTabHelper* helper = FindTabHelper::FromWebState(webState);

+ DCHECK(helper);

+ helper->StopFinding(nil);

+ }

}

- (void)findResultsAvailable:(FindInPageModel*)model {

« no previous file with comments | « no previous file | ios/clean/chrome/browser/ui/tab_collection/tab_collection_consumer.h » ('j') | no next file with comments »