content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 2903833002: Reland: Update TextSelection for non-user initiated events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 2903833002: Reland: Update TextSelection for non-user initiated events

Patch Set: Add test for JS cursor movement Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index f123f53d55792ea1b19ba2b45d447a67ad18ebf4..b7761130cce3123aba6c60224bbc074c3b9c9fff 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -1398,7 +1398,7 @@ void PepperPluginInstanceImpl::SetSelectedText(

selected_text_ = selected_text;

gfx::Range range(0, selected_text.length());

- render_frame_->SetSelectedText(selected_text, 0, range);

+ render_frame_->SetSelectedText(selected_text, 0, range, true);

}

void PepperPluginInstanceImpl::SetLinkUnderCursor(const std::string& url) {