content/renderer/input/frame_input_handler_impl.cc - Issue 2903833002: Reland: Update TextSelection for non-user initiated events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/input/frame_input_handler_impl.cc

Issue 2903833002: Reland: Update TextSelection for non-user initiated events

Patch Set: Add test for JS cursor movement Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/input/frame_input_handler_impl.cc

diff --git a/content/renderer/input/frame_input_handler_impl.cc b/content/renderer/input/frame_input_handler_impl.cc

index 52c00fa5f281c20c610f1509650af047e2adb3a4..909207f674fd2ab7363e54c9f7cf2796f91a2448 100644

--- a/content/renderer/input/frame_input_handler_impl.cc

+++ b/content/renderer/input/frame_input_handler_impl.cc

@@ -219,7 +219,7 @@ void FrameInputHandlerImpl::Replace(const base::string16& word) {

if (frame->HasSelection())

frame->SelectWordAroundCaret();

frame->ReplaceSelection(blink::WebString::FromUTF16(word));

- render_frame_->SyncSelectionIfRequired();

+ render_frame_->SyncSelectionIfRequired(true);

}

void FrameInputHandlerImpl::ReplaceMisspelling(const base::string16& word) {