content/browser/frame_host/render_frame_host_impl.cc - Issue 2903833002: Reland: Update TextSelection for non-user initiated events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2903833002: Reland: Update TextSelection for non-user initiated events

Patch Set: Add test for JS cursor movement Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index fba3353ef1d1eab0769843ff23b82141dfb56693..2435ef37f1896a8206f6b6bdc1eb3a7db0c7e034 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -2615,9 +2615,10 @@ void RenderFrameHostImpl::OnSerializeAsMHTMLResponse(

void RenderFrameHostImpl::OnSelectionChanged(const base::string16& text,

uint32_t offset,

- const gfx::Range& range) {

+ const gfx::Range& range,

+ bool user_initiated) {

has_selection_ = !text.empty();

- GetRenderWidgetHost()->SelectionChanged(text, offset, range);

+ GetRenderWidgetHost()->SelectionChanged(text, offset, range, user_initiated);

}

void RenderFrameHostImpl::OnFocusedNodeChanged(