Test for OscillatorNode.type=.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 5597 matching lines @@
     intptr_t cid = raw()->GetClassId();
     return ElementType(cid);
   }
 
   intptr_t LengthInBytes() const {
     intptr_t cid = raw()->GetClassId();
     return (ElementSizeInBytes(cid) * Length());
   }
 
   void* DataAddr(intptr_t byte_offset) const {
-    ASSERT((byte_offset >= 0) && (byte_offset < LengthInBytes()));
+    ASSERT((byte_offset == 0) ||
+          ((byte_offset >= 0) && (byte_offset < LengthInBytes())));

[siva, 2013/10/22 00:08:53]

Not sure what the value of byte_offset is in this case?

[rmacnak, 2013/10/22 00:28:21]

byte_offset == 0 handles the case where the array is of length 0.

[siva, 2013/10/22 18:26:49]

In that case should the assert be changed to
ASSERT((byte_offset == 0) || ((byte_offset > 0) && (byte_offset <
LengthInBytes()));

     return reinterpret_cast<void*>(raw_ptr()->data_ + byte_offset);
   }
 
 #define TYPED_GETTER_SETTER(name, type)                                        \
   type Get##name(intptr_t byte_offset) const {                                 \
     return *reinterpret_cast<type*>(DataAddr(byte_offset));                    \
   }                                                                            \
   void Set##name(intptr_t byte_offset, type value) const {                     \
     *reinterpret_cast<type*>(DataAddr(byte_offset)) = value;                   \
   }
@@ skipping 111 matching lines @@
   intptr_t LengthInBytes() const {
     intptr_t cid = raw()->GetClassId();
     return (ElementSizeInBytes(cid) * Length());
   }
 
   void* GetPeer() const {
     return raw_ptr()->peer_;
   }
 
   void* DataAddr(intptr_t byte_offset) const {
-    ASSERT((byte_offset >= 0) && (byte_offset < LengthInBytes()));
+    ASSERT((byte_offset == 0) ||
+          ((byte_offset >= 0) && (byte_offset < LengthInBytes())));

[siva, 2013/10/22 18:26:49]

Ditto.

     return reinterpret_cast<void*>(raw_ptr()->data_ + byte_offset);
   }
 
 #define TYPED_GETTER_SETTER(name, type)                                        \
   type Get##name(intptr_t byte_offset) const {                                 \
     return *reinterpret_cast<type*>(DataAddr(byte_offset));                    \
   }                                                                            \
   void Set##name(intptr_t byte_offset, type value) const {                     \
     *reinterpret_cast<type*>(DataAddr(byte_offset)) = value;                   \
   }
@@ skipping 519 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_