Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h

Issue 289193003: Convert a bunch of BPF_TEST tests to use BPF_TEST_C (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add default constructors too Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sandbox/linux/seccomp-bpf/bpf_tests.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h
diff --git a/sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h b/sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h
index 5c2f3416b901447ce2d523ae7e69df843c2c9727..8890f798749a4c896439f51de889dd1070dea439 100644
--- a/sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h
+++ b/sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h
@@ -17,30 +17,6 @@
namespace sandbox {
-namespace internal {
-
-// Internal helper class to hold a value of type T.
-template <typename T>
-class AuxHolder {
- public:
- AuxHolder() : val_() {}
- T* get() { return &val_; }
-
- private:
- T val_;
-};
-
-// Specialization of AuxHolder for void.
-// Returns a null pointer instead of allocating void.
-template <>
-class AuxHolder<void> {
- public:
- AuxHolder() {}
- void* get() { return NULL; }
-};
-
-} // namespace internal
-
// This templated class allows building a BPFTesterDelegate from a
// deprecated-style BPF policy (that is a SyscallEvaluator function pointer,
// instead of a SandboxBPFPolicy class), specified in |policy_function| and a
@@ -48,14 +24,14 @@ class AuxHolder<void> {
// This allows both the policy and the test function to take a pointer to an
// object of type "Aux" as a parameter. This is used to implement the BPF_TEST
// macro and should generally not be used directly.
-template <class Aux = void>
+template <class Aux>
class BPFTesterCompatibilityDelegate : public BPFTesterDelegate {
public:
typedef Aux AuxType;
BPFTesterCompatibilityDelegate(
void (*test_function)(AuxType*),
typename CompatibilityPolicy<AuxType>::SyscallEvaluator policy_function)
- : aux_holder_(),
+ : aux_(),
test_function_(test_function),
policy_function_(policy_function) {}
@@ -67,18 +43,18 @@ class BPFTesterCompatibilityDelegate : public BPFTesterDelegate {
// to live forever. So it's ok to pass aux_pointer_for_policy_ to
// the policy, which could in turn pass it to the kernel via Trap().
return scoped_ptr<SandboxBPFPolicy>(
- new CompatibilityPolicy<AuxType>(policy_function_, aux_holder_.get()));
+ new CompatibilityPolicy<AuxType>(policy_function_, &aux_));
}
virtual void RunTestFunction() OVERRIDE {
// Run the actual test.
// The current object is guaranteed to live forever in the child process
// where this will run.
- test_function_(aux_holder_.get());
+ test_function_(&aux_);
}
private:
- internal::AuxHolder<AuxType> aux_holder_;
+ AuxType aux_;
void (*test_function_)(AuxType*);
typename CompatibilityPolicy<AuxType>::SyscallEvaluator policy_function_;
DISALLOW_COPY_AND_ASSIGN(BPFTesterCompatibilityDelegate);
« no previous file with comments | « no previous file | sandbox/linux/seccomp-bpf/bpf_tests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698