content/browser/download/download_item_impl.cc - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_item_impl.cc

diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc

index a5d7db8cef5fad91838d9b6860063d10a6408265..d02b26f6497474ec052023d0baf7d9c112d16cd9 100644

--- a/content/browser/download/download_item_impl.cc

+++ b/content/browser/download/download_item_impl.cc

@@ -1116,7 +1116,8 @@ void DownloadItemImpl::UpdateValidatorsOnResumption(

}

if (content_disposition_ != new_create_info.content_disposition)

origin_state |= ORIGIN_STATE_ON_RESUMPTION_CONTENT_DISPOSITION_CHANGED;

- RecordOriginStateOnResumption(is_partial, origin_state);

+ RecordOriginStateOnResumption(

+ is_partial, static_cast<OriginStateOnResumption>(origin_state));

request_info_.url_chain.insert(request_info_.url_chain.end(), chain_iter,

new_create_info.url_chain.end());