components/signin/core/browser/signin_metrics.cc - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_metrics.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/signin_metrics.cc

diff --git a/components/signin/core/browser/signin_metrics.cc b/components/signin/core/browser/signin_metrics.cc

index d754cf87a305c643ee3fd47496a003e2c36f34b5..7daf5965000bffe4440b9fc11b27480261b8b28d 100644

--- a/components/signin/core/browser/signin_metrics.cc

+++ b/components/signin/core/browser/signin_metrics.cc

@@ -186,7 +186,7 @@ void LogAuthError(GoogleServiceAuthError::State auth_error) {

GoogleServiceAuthError::State::NUM_STATES);

}

-void LogSigninConfirmHistogramValue(int action) {

+void LogSigninConfirmHistogramValue(ConfirmationUsage action) {

UMA_HISTOGRAM_ENUMERATION("Signin.OneClickConfirmation", action,

signin_metrics::HISTOGRAM_CONFIRM_MAX);

}