chrome/browser/ui/webui/app_launcher_login_handler.h - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/app_launcher_login_handler.h

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/app_launcher_login_handler.h

diff --git a/chrome/browser/ui/webui/app_launcher_login_handler.h b/chrome/browser/ui/webui/app_launcher_login_handler.h

index f678091feecbae079c03923cd4c4d6ba9cfb2d1d..e99e4916175e91135d6caccd086db5ab348a3c3e 100644

--- a/chrome/browser/ui/webui/app_launcher_login_handler.h

+++ b/chrome/browser/ui/webui/app_launcher_login_handler.h

@@ -54,7 +54,7 @@ class AppLauncherLoginHandler : public content::WebUIMessageHandler {

void HandleShowSyncLoginUI(const base::ListValue* args);

// Records actions in SyncPromo.NTPPromo histogram.

- void RecordInHistogram(int type);

+ void RecordInHistogram(NTPSignInPromoBuckets type);

// Called from JS when the sync promo NTP bubble has been displayed. |args| is

// the list of arguments passed from JS and should be an empty list.