chrome/browser/ui/toolbar/app_menu_model.h - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/app_menu_model.h

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/app_menu_model.h

diff --git a/chrome/browser/ui/toolbar/app_menu_model.h b/chrome/browser/ui/toolbar/app_menu_model.h

index 80dccccea6d3ada98efe84c3d1bb44478db5779b..980ba8b9b8785c7eca2ae5b7ea3121c2e089e231 100644

--- a/chrome/browser/ui/toolbar/app_menu_model.h

+++ b/chrome/browser/ui/toolbar/app_menu_model.h

@@ -186,7 +186,7 @@ class AppMenuModel : public ui::SimpleMenuModel,

void LogMenuMetrics(int command_id);

// Helper function to record the menu action in a UMA histogram.

- void LogMenuAction(int action_id);

+ void LogMenuAction(AppMenuAction action_id);

// Time menu has been open. Used by LogMenuMetrics() to record the time

// to action when the user selects a menu item.