base/metrics/histogram_functions_unittest.cc - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_functions_unittest.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: simplify type checking Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_functions_unittest.cc

diff --git a/base/metrics/histogram_functions_unittest.cc b/base/metrics/histogram_functions_unittest.cc

index 77a584bb12cda2f46cc532ec5974e3c873a3a3ae..7bfd202e2dc879d8a7edb94ff12e19c73bfa268f 100644

--- a/base/metrics/histogram_functions_unittest.cc

+++ b/base/metrics/histogram_functions_unittest.cc

@@ -47,7 +47,7 @@ TEST(HistogramFunctionsTest, HistogramEnumeration) {

// Verify the overflow & underflow bucket exists.

UMA_HISTOGRAM_ENUMERATION(

histogram, static_cast<int>(UMA_HISTOGRAM_TESTING_ENUM_THIRD) + 10,

- UMA_HISTOGRAM_TESTING_ENUM_THIRD);

+ static_cast<int>(UMA_HISTOGRAM_TESTING_ENUM_THIRD));

tester.ExpectBucketCount(

histogram, static_cast<int>(UMA_HISTOGRAM_TESTING_ENUM_THIRD) + 1, 1);

tester.ExpectTotalCount(histogram, 2);

« no previous file with comments | « base/debug/activity_tracker.cc ('k') | base/metrics/histogram_macros_internal.h » ('j') | no next file with comments »