Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

components/signin/core/browser/signin_metrics.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
 
 #include <limits.h>
 
 #include "base/time/time.h"
@@ skipping 35 matching lines @@
   // The credentials are being transfered to a new profile, so the old one is
   // signed out.
   TRANSFER_CREDENTIALS,
   // Signed out because credentials are invalid and force-sign-in is enabled.
   AUTHENTICATION_FAILED_WITH_FORCE_SIGNIN,
   // Keep this as the last enum.
   NUM_PROFILE_SIGNOUT_METRICS,
 };
 
 // Enum values used for use with "AutoLogin.Reverse" histograms.
-enum {
+enum APAction {
   // The infobar was shown to the user.
   HISTOGRAM_SHOWN,
   // The user pressed the accept button to perform the suggested action.
   HISTOGRAM_ACCEPTED,
   // The user pressed the reject to turn off the feature.
   HISTOGRAM_REJECTED,
   // The user pressed the X button to dismiss the infobar this time.
   HISTOGRAM_DISMISSED,
   // The user completely ignored the infoar.  Either they navigated away, or
   // they used the page as is.
   HISTOGRAM_IGNORED,
   // The user clicked on the learn more link in the infobar.
   HISTOGRAM_LEARN_MORE,
   // The sync was started with default settings.
   HISTOGRAM_WITH_DEFAULTS,
   // The sync was started with advanced settings.
   HISTOGRAM_WITH_ADVANCED,
   // The sync was started through auto-accept with default settings.
   HISTOGRAM_AUTO_WITH_DEFAULTS,
   // The sync was started through auto-accept with advanced settings.
   HISTOGRAM_AUTO_WITH_ADVANCED,
   // The sync was aborted with an undo button.
   HISTOGRAM_UNDO,
   HISTOGRAM_MAX
 };
 
 // Enum values used with the "Signin.OneClickConfirmation" histogram, which
 // tracks the actions used in the OneClickConfirmation bubble.
-enum {
+enum ConfirmationUsage {
   HISTOGRAM_CONFIRM_SHOWN,
   HISTOGRAM_CONFIRM_OK,
   HISTOGRAM_CONFIRM_RETURN,
   HISTOGRAM_CONFIRM_ADVANCED,
   HISTOGRAM_CONFIRM_CLOSE,
   HISTOGRAM_CONFIRM_ESCAPE,
   HISTOGRAM_CONFIRM_UNDO,
   HISTOGRAM_CONFIRM_LEARN_MORE,
   HISTOGRAM_CONFIRM_LEARN_MORE_OK,
   HISTOGRAM_CONFIRM_LEARN_MORE_RETURN,
@@ skipping 250 matching lines @@
 // Tracks whether the external connection results were all fetched before
 // the gaia cookie manager service tried to use them with merge session.
 // |time_to_check_connections| is the time it took to complete.
 void LogExternalCcResultFetches(
     bool fetches_completed,
     const base::TimeDelta& time_to_check_connections);
 
 // Track when the current authentication error changed.
 void LogAuthError(GoogleServiceAuthError::State auth_error);
 
-void LogSigninConfirmHistogramValue(int action);
+void LogSigninConfirmHistogramValue(ConfirmationUsage action);
 
 void LogXDevicePromoEligible(CrossDevicePromoEligibility metric);
 
 void LogXDevicePromoInitialized(CrossDevicePromoInitialized metric);
 
 void LogBrowsingSessionDuration(const base::Time& previous_activity_time);
 
 // Records the AccountReconcilor |state| when GAIA returns a specific response.
 // If |state| is different than ACCOUNT_RECONCILOR_OK it means the user will
 // be shown a different set of accounts in the content-area and the settings UI.
@@ skipping 55 matching lines @@
       UMA_HISTOGRAM_ENUMERATION(name "_Periodic", sample, boundary_value);     \
       break;                                                                   \
     case ReportingType::ON_CHANGE:                                             \
       UMA_HISTOGRAM_ENUMERATION(name "_OnChange", sample, boundary_value);     \
       break;                                                                   \
   }
 
 }  // namespace signin_metrics
 
 #endif  // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_