Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: simplify type checking Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler_impl.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 #include "content/public/browser/web_ui.h" 65 #include "content/public/browser/web_ui.h"
66 #include "google_apis/gaia/gaia_auth_fetcher.h" 66 #include "google_apis/gaia/gaia_auth_fetcher.h"
67 #include "google_apis/gaia/gaia_auth_util.h" 67 #include "google_apis/gaia/gaia_auth_util.h"
68 #include "google_apis/gaia/gaia_constants.h" 68 #include "google_apis/gaia/gaia_constants.h"
69 #include "google_apis/gaia/gaia_urls.h" 69 #include "google_apis/gaia/gaia_urls.h"
70 #include "net/base/url_util.h" 70 #include "net/base/url_util.h"
71 #include "ui/base/l10n/l10n_util.h" 71 #include "ui/base/l10n/l10n_util.h"
72 72
73 namespace { 73 namespace {
74 74
75 void LogHistogramValue(int action) { 75 void LogHistogramValue(signin_metrics::APAction action) {
76 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action, 76 UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action,
77 signin_metrics::HISTOGRAM_MAX); 77 signin_metrics::HISTOGRAM_MAX);
78 } 78 }
79 79
80 // Returns true if |profile| is a system profile or created from one. 80 // Returns true if |profile| is a system profile or created from one.
81 bool IsSystemProfile(Profile* profile) { 81 bool IsSystemProfile(Profile* profile) {
82 return profile->GetOriginalProfile()->IsSystemProfile(); 82 return profile->GetOriginalProfile()->IsSystemProfile();
83 } 83 }
84 84
85 void RedirectToNtpOrAppsPage(content::WebContents* contents, 85 void RedirectToNtpOrAppsPage(content::WebContents* contents,
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
874 874
875 if (show_account_management) { 875 if (show_account_management) {
876 browser->window()->ShowAvatarBubbleFromAvatarButton( 876 browser->window()->ShowAvatarBubbleFromAvatarButton(
877 BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT, 877 BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
878 signin::ManageAccountsParams(), 878 signin::ManageAccountsParams(),
879 signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN, 879 signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN,
880 false); 880 false);
881 } 881 }
882 } 882 }
883 } 883 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/app_launcher_login_handler.cc ('k') | components/leveldb/public/cpp/util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698