Move the user interaction policy for FirstMeaningfulPaint UMA into renderer

third_party/WebKit/Source/core/paint/PaintTiming.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintTiming.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/LocalFrameView.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/ProgressTracker.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/Page.h"
 #include "core/timing/DOMWindowPerformance.h"
 #include "core/timing/Performance.h"
+#include "platform/Histogram.h"
 #include "platform/WebFrameScheduler.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "public/platform/WebLayerTreeView.h"
 
 namespace blink {
 
 namespace {
 
 Performance* GetPerformanceInstance(LocalFrame* frame) {
   Performance* performance = nullptr;
@@ skipping 62 matching lines @@
 
 void PaintTiming::SetFirstMeaningfulPaintCandidate(double timestamp) {
   if (first_meaningful_paint_candidate_)
     return;
   first_meaningful_paint_candidate_ = timestamp;
   if (GetFrame() && GetFrame()->View() && !GetFrame()->View()->IsAttached()) {
     GetFrame()->FrameScheduler()->OnFirstMeaningfulPaint();
   }
 }
 
-void PaintTiming::SetFirstMeaningfulPaint(double stamp) {
+void PaintTiming::SetFirstMeaningfulPaint(
+    double stamp,
+    FirstMeaningfulPaintDetector::HadUserInput had_input) {
   DCHECK_EQ(first_meaningful_paint_, 0.0);
-  first_meaningful_paint_ = stamp;
-  TRACE_EVENT_MARK_WITH_TIMESTAMP1(
-      "loading,rail,devtools.timeline", "firstMeaningfulPaint",
-      TraceEvent::ToTraceTimestamp(first_meaningful_paint_), "frame",
-      GetFrame());
-  NotifyPaintTimingChanged();
-  RegisterNotifySwapTime(PaintEvent::kFirstMeaningfulPaint);
+  TRACE_EVENT_MARK_WITH_TIMESTAMP2("loading,rail,devtools.timeline",
+                                   "firstMeaningfulPaint",
+                                   TraceEvent::ToTraceTimestamp(stamp), "frame",
+                                   GetFrame(), "afterUserInput", had_input);
+
+  // Notify FMP for UMA only if there's no user input before FMP, so that layout
+  // changes caused by user interactions wouldn't be considered as FMP.
+  if (had_input == FirstMeaningfulPaintDetector::kNoUserInput) {
+    first_meaningful_paint_ = stamp;
+    NotifyPaintTimingChanged();
+    RegisterNotifySwapTime(PaintEvent::kFirstMeaningfulPaint);
+  }
+
+  ReportUserInputHistogram(had_input);
+}
+
+void PaintTiming::ReportUserInputHistogram(
+    FirstMeaningfulPaintDetector::HadUserInput had_input) {
+  DEFINE_STATIC_LOCAL(EnumerationHistogram, had_user_input_histogram,
+                      ("PageLoad.Internal.PaintTiming."
+                       "HadUserInputBeforeFirstMeaningfulPaint",
+                       FirstMeaningfulPaintDetector::kHadUserInputEnumMax));
+
+  if (GetFrame() && GetFrame()->IsMainFrame())
+    had_user_input_histogram.Count(had_input);
 }
 
 void PaintTiming::NotifyPaint(bool is_first_paint,
                               bool text_painted,
                               bool image_painted) {
   if (is_first_paint)
     MarkFirstPaint();
   if (text_painted)
     MarkFirstTextPaint();
   if (image_painted)
@@ skipping 71 matching lines @@
         performance->AddFirstContentfulPaintTiming(first_contentful_paint_);
       return;
     case PaintEvent::kFirstMeaningfulPaint:
       first_meaningful_paint_swap_ = timestamp;
       return;
   }
   NOTREACHED();
 }
 
 }  // namespace blink