chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java - Issue 2853583002: 🏠 Add expand button and flag to enable it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java

Issue 2853583002: 🏠 Add expand button and flag to enable it (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java

index 05b33ef1fabc42923d6ed85772d37c5685e7bd43..e5136e077037926ea834596f701c29c7e51f15f4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java

@@ -22,13 +22,15 @@ public class BottomSheetMetrics extends EmptyBottomSheetObserver {

* The different ways that the bottom sheet can be opened. This is used to back a UMA

* histogram and should therefore be treated as append-only.

- @IntDef({OPENED_BY_SWIPE, OPENED_BY_OMNIBOX_FOCUS, OPENED_BY_NEW_TAB_CREATION})

+ @IntDef({OPENED_BY_SWIPE, OPENED_BY_OMNIBOX_FOCUS, OPENED_BY_NEW_TAB_CREATION,

+ OPENED_BY_EXPAND_BUTTON})

@Retention(RetentionPolicy.SOURCE)

public @interface SheetOpenReason {}

public static final int OPENED_BY_SWIPE = 0;

public static final int OPENED_BY_OMNIBOX_FOCUS = 1;

public static final int OPENED_BY_NEW_TAB_CREATION = 2;

- private static final int OPENED_BY_BOUNDARY = 3;

+ public static final int OPENED_BY_EXPAND_BUTTON = 3;

+ private static final int OPENED_BY_BOUNDARY = 4;

/** Whether the sheet is currently open. */

private boolean mIsSheetOpen;