Omit .Get() on calls to DataEquivalent in StyleRareInheritedData.

Omit .Get() on calls to DataEquivalent in StyleRareInheritedData.

StyleRareInheritedData contains a few members stored as RefPtr<> or
Persistent<>. To compare these members, we can't use == because that
performs a pointer comparison, so instead we use a helper method called
DataEquivalent that checks both the pointer and the data itself.

For some members, DataEquivalent is being used like this:

  DataEquivalent(foo.Get(), o.foo.Get())

However, DataEquivalent is overloaded for RefPtr and Persistent, so we
can do this instead:

  DataEquivalent(foo, o.foo)

This patch removes .Get() calls on DataEquivalent to take advantage of
the overloads.

BUG=628043
Review-Url: https://codereview.chromium.org/2852873002
Cr-Commit-Position: refs/heads/master@{#468914}
Committed: https://chromium.googlesource.com/chromium/src/+/fa4d44124befc9b262884ea7af6e53b87f0baf03

[shend, 2017-04-30 23:03:27]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-30 23:03:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-01 00:17:13]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-05-01 00:17:14]

Hi Bugs, PTAL

[commit-bot: I haz the power, 2017-05-01 00:30:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 00:30:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bugs Nash, 2017-05-01 23:00:17]

lgtm

[shend, 2017-05-01 23:51:45]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-05-01 23:51:46]

Hi Eddy, PTAL :)

[meade_UTC10, 2017-05-03 03:15:09]

lgtm

[shend, 2017-05-03 05:35:18]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-03 05:35:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 07:07:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493789718218680, "parent_rev":
"84f04dbf558f6c3391ef4115e45d7c0ddefc0f00", "commit_rev":
"fa4d44124befc9b262884ea7af6e53b87f0baf03"}

[commit-bot: I haz the power, 2017-05-03 07:07:29]

Description was changed from

==========
Omit .Get() on calls to DataEquivalent in StyleRareInheritedData.

StyleRareInheritedData contains a few members stored as RefPtr<> or
Persistent<>. To compare these members, we can't use == because that
performs a pointer comparison, so instead we use a helper method called
DataEquivalent that checks both the pointer and the data itself.

For some members, DataEquivalent is being used like this:

  DataEquivalent(foo.Get(), o.foo.Get())

However, DataEquivalent is overloaded for RefPtr and Persistent, so we
can do this instead:

  DataEquivalent(foo, o.foo)

This patch removes .Get() calls on DataEquivalent to take advantage of
the overloads.

BUG=628043
==========

to

==========
Omit .Get() on calls to DataEquivalent in StyleRareInheritedData.

StyleRareInheritedData contains a few members stored as RefPtr<> or
Persistent<>. To compare these members, we can't use == because that
performs a pointer comparison, so instead we use a helper method called
DataEquivalent that checks both the pointer and the data itself.

For some members, DataEquivalent is being used like this:

  DataEquivalent(foo.Get(), o.foo.Get())

However, DataEquivalent is overloaded for RefPtr and Persistent, so we
can do this instead:

  DataEquivalent(foo, o.foo)

This patch removes .Get() calls on DataEquivalent to take advantage of
the overloads.

BUG=628043

Review-Url: https://codereview.chromium.org/2852873002
Cr-Commit-Position: refs/heads/master@{#468914}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa4d44124befc9b262884ea7af6e...
==========

[commit-bot: I haz the power, 2017-05-03 07:07:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa4d44124befc9b262884ea7af6e...