Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2852433005:
Changing default Windows compiler to VS 2017 (Closed)
|
Created:
3 years, 7 months ago by brucedawson Modified:
3 years, 7 months ago Reviewers:
Nico CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChanging default Windows compiler to VS 2017
This is a single character change to temporarily switch Chrome to
building with VC++ 2017. This CL is currently purely for testing
purposes and will be landed for the weekend in order to flesh out any
remaining bugs.
This is a retry of crrev.com/2762093003 which failed due to a compiler
warning which was missed in local testing and the try bots. That warning
has been resolved and a local build of 'all' completed cleanly.
BUG=683729
Review-Url: https://codereview.chromium.org/2852433005
Cr-Commit-Position: refs/heads/master@{#468239}
Committed: https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564792272ed34a3
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Changing default Windows compiler to VS 2017 This is a single character change to temporarily switch Chrome to building with VC++ 2017. This CL is currently purely for testing purposes and will be landed for the weekend in order to flesh out any remaining bugs. BUG=683729 ========== to ========== Changing default Windows compiler to VS 2017 This is a single character change to temporarily switch Chrome to building with VC++ 2017. This CL is currently purely for testing purposes and will be landed for the weekend in order to flesh out any remaining bugs. This is a retry of crrev.com/2762093003 which failed due to a compiler warning which was missed in local testing and the try bots. That warning has been resolved and a local build of 'all' completed cleanly. BUG=683729 ==========
brucedawson@chromium.org changed reviewers: + thakis@chromium.org
As before, planning to land this for the weekend, revert on Sunday.
lgtm
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493466248870240, "parent_rev":
"a916ec8af80b660d45454ccdf5b88d97249327a8", "commit_rev":
"060d293f1d87d450a824dc46f564792272ed34a3"}
Message was sent while issue was closed.
Description was changed from ========== Changing default Windows compiler to VS 2017 This is a single character change to temporarily switch Chrome to building with VC++ 2017. This CL is currently purely for testing purposes and will be landed for the weekend in order to flesh out any remaining bugs. This is a retry of crrev.com/2762093003 which failed due to a compiler warning which was missed in local testing and the try bots. That warning has been resolved and a local build of 'all' completed cleanly. BUG=683729 ========== to ========== Changing default Windows compiler to VS 2017 This is a single character change to temporarily switch Chrome to building with VC++ 2017. This CL is currently purely for testing purposes and will be landed for the weekend in order to flesh out any remaining bugs. This is a retry of crrev.com/2762093003 which failed due to a compiler warning which was missed in local testing and the try bots. That warning has been resolved and a local build of 'all' completed cleanly. BUG=683729 Review-Url: https://codereview.chromium.org/2852433005 Cr-Commit-Position: refs/heads/master@{#468239} Committed: https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564...
Message was sent while issue was closed.
On 2017/04/29 11:48:01, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/060d293f1d87d450a824dc46f564... One build failure (GPU Win Builder) attributed to this change (tree closed) looks unrelated. Goma crash? E0429 05:22:38.617375 4368 named_pipe_client_win.cc:42] Timed-out to create new pipe:\\.\pipe\goma.ipc compiler proxy isn't running. Exiting. Tree reopened.
Message was sent while issue was closed.
Failure link, 'cause I hate when those are omitted: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.gpu%2FGPU_Win_B... The next build succeeded so the waterfall is as green as it gets.
Message was sent while issue was closed.
I just checked the Chromium build waterfall. There are lots of perf failures, such as Win 10 Perf, but almost all have been failing consistently for days/weeks. Win7 Debug (AMD) - https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29 - started failing today but build 1796 is the one that included this change and it passed, as did the two subsequent builds. Win10 Release (NVIDIA) - https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28N... - started failing today but build 1644 is the one that included this change and it passed, as did 1645. So, no sign of problems so far. A VS 2017 canary build has not yet showed up (60.0.3084.0 is still VS 2015).
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2851143002/ by brucedawson@chromium.org. The reason for reverting is: Reverting as planned - it was just a test switch to VS 2017, which seems to have gone smoothly, although crash results still need examination. Canary 60.0.3085.0 was built with VS 2017..
Message was sent while issue was closed.
> Canary 60.0.3085.0 was built with VS 2017. Oops. No it wasn't. No canary versions were. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
