chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc - Issue 2851103002: Update some host_resolver()->AddRules in chrome/browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

Issue 2851103002: Update some host_resolver()->AddRules in chrome/browser. (Closed)

Patch Set: fix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/history/history_apitest.cc ('k') | chrome/browser/extensions/api/page_capture/page_capture_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

diff --git a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

index 245cff89ea3f45f08c75e16e962857ae0145b5be..39affc20eed9d2fe8d8b2e90cc03cb54bffbf0aa 100644

--- a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

+++ b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

@@ -74,6 +74,7 @@ class LogPrivateApiTest : public ExtensionApiTest {

chromeos::DBusThreadManager::GetSetterForTesting()->SetDebugDaemonClient(

std::unique_ptr<chromeos::DebugDaemonClient>(

new TestDebugDaemonClient(tar_file_path)));

+ host_resolver()->AddRule("www.test.com", "127.0.0.1");

ExtensionApiTest::SetUpInProcessBrowserTestFixture();

}

@@ -89,7 +90,6 @@ class LogPrivateApiTest : public ExtensionApiTest {

IN_PROC_BROWSER_TEST_F(LogPrivateApiTest, DumpLogsAndCaptureEvents) {

// Setup dummy HTTP server.

- host_resolver()->AddRule("www.test.com", "127.0.0.1");

embedded_test_server()->RegisterRequestHandler(

base::Bind(&LogPrivateApiTest::HandleRequest, base::Unretained(this)));

ASSERT_TRUE(StartEmbeddedTestServer());