Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6534)

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter.cc

Issue 2850033002: Check Expect-CT at connection setup (Closed)
Patch Set: fix comment typo Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_expect_ct_reporter.cc
diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter.cc b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
index e9e883dfebf34d50e2d98106b2280d6cd6561580..3cb1168daf3f0c0fa7ae723ddf518ffb7e4bd3a5 100644
--- a/chrome/browser/ssl/chrome_expect_ct_reporter.cc
+++ b/chrome/browser/ssl/chrome_expect_ct_reporter.cc
@@ -125,7 +125,10 @@ ChromeExpectCTReporter::~ChromeExpectCTReporter() {}
void ChromeExpectCTReporter::OnExpectCTFailed(
const net::HostPortPair& host_port_pair,
const GURL& report_uri,
- const net::SSLInfo& ssl_info) {
+ const net::X509Certificate* validated_certificate_chain,
+ const net::X509Certificate* served_certificate_chain,
+ const net::SignedCertificateTimestampAndStatusList&
+ signed_certificate_timestamps) {
if (report_uri.is_empty())
return;
@@ -140,15 +143,15 @@ void ChromeExpectCTReporter::OnExpectCTFailed(
report.SetInteger("port", host_port_pair.port());
report.SetString("date-time", TimeToISO8601(base::Time::Now()));
report.Set("served-certificate-chain",
- GetPEMEncodedChainAsList(ssl_info.unverified_cert.get()));
+ GetPEMEncodedChainAsList(served_certificate_chain));
report.Set("validated-certificate-chain",
- GetPEMEncodedChainAsList(ssl_info.cert.get()));
+ GetPEMEncodedChainAsList(validated_certificate_chain));
std::unique_ptr<base::ListValue> unknown_scts(new base::ListValue());
std::unique_ptr<base::ListValue> invalid_scts(new base::ListValue());
std::unique_ptr<base::ListValue> valid_scts(new base::ListValue());
- for (const auto& sct_and_status : ssl_info.signed_certificate_timestamps) {
+ for (const auto& sct_and_status : signed_certificate_timestamps) {
switch (sct_and_status.status) {
case net::ct::SCT_STATUS_LOG_UNKNOWN:
AddUnknownSCT(sct_and_status, unknown_scts.get());
« no previous file with comments | « chrome/browser/ssl/chrome_expect_ct_reporter.h ('k') | chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698