Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2847933002: Convert MultiActivityTestBase children to JUnit4 (Closed)

Created:
3 years, 7 months ago by the real yoland
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MultiActivityTestBase children to JUnit4 The follows the same pattern created for chrome activity test rules and test base, where test rules and test bases share as much same implementation as possible in the test common classes during the migration. For more on JUnit4 migration, please check src/testing/android/docs/junit4.md BUG=640116 Review-Url: https://codereview.chromium.org/2847933002 Cr-Commit-Position: refs/heads/master@{#468521} Committed: https://chromium.googlesource.com/chromium/src/+/95b984c544b0216c36a04231151a6509ac7240d5

Patch Set 1 #

Patch Set 2 : supress findbug warning #

Total comments: 4

Patch Set 3 : Add imports and rebase #

Messages

Total messages: 29 (22 generated)
the real yoland
Hi Dan, I remember you said to be working on first run test or test ...
3 years, 7 months ago (2017-04-28 18:17:22 UTC) #8
jbudorick
lgtm
3 years, 7 months ago (2017-04-28 22:58:39 UTC) #14
gone
https://codereview.chromium.org/2847933002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java (left): https://codereview.chromium.org/2847933002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java#oldcode34 chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java:34: @CommandLineFlags.Remove(ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE) This file explicitly removed the flag because it ...
3 years, 7 months ago (2017-04-30 02:00:14 UTC) #17
the real yoland
https://codereview.chromium.org/2847933002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java (left): https://codereview.chromium.org/2847933002/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java#oldcode34 chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java:34: @CommandLineFlags.Remove(ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE) On 2017/04/30 at 02:00:14, slow (dfalcantara) wrote: > ...
3 years, 7 months ago (2017-05-01 23:35:36 UTC) #18
gone
Well, lgtm if the tests still pass.
3 years, 7 months ago (2017-05-01 23:36:24 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847933002/60001
3 years, 7 months ago (2017-05-02 01:08:44 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 01:13:16 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/95b984c544b0216c36a04231151a...

Powered by Google App Engine
This is Rietveld 408576698