[WASM SIMD] Replace primitive shuffles with general Shuffle.

src/compiler/wasm-compiler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/wasm-compiler.h"
 
 #include <memory>
 
 #include "src/assembler-inl.h"
 #include "src/base/platform/elapsed-timer.h"
@@ skipping 3460 matching lines @@
       return graph()->NewNode(jsgraph()->machine()->S128And(), inputs[0],
                               inputs[1]);
     case wasm::kExprS128Or:
       return graph()->NewNode(jsgraph()->machine()->S128Or(), inputs[0],
                               inputs[1]);
     case wasm::kExprS128Xor:
       return graph()->NewNode(jsgraph()->machine()->S128Xor(), inputs[0],
                               inputs[1]);
     case wasm::kExprS128Not:
       return graph()->NewNode(jsgraph()->machine()->S128Not(), inputs[0]);
-    case wasm::kExprS32x4ZipLeft:
-      return graph()->NewNode(jsgraph()->machine()->S32x4ZipLeft(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS32x4ZipRight:
-      return graph()->NewNode(jsgraph()->machine()->S32x4ZipRight(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS32x4UnzipLeft:
-      return graph()->NewNode(jsgraph()->machine()->S32x4UnzipLeft(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS32x4UnzipRight:
-      return graph()->NewNode(jsgraph()->machine()->S32x4UnzipRight(),
-                              inputs[0], inputs[1]);
-    case wasm::kExprS32x4TransposeLeft:
-      return graph()->NewNode(jsgraph()->machine()->S32x4TransposeLeft(),
-                              inputs[0], inputs[1]);
-    case wasm::kExprS32x4TransposeRight:
-      return graph()->NewNode(jsgraph()->machine()->S32x4TransposeRight(),
-                              inputs[0], inputs[1]);
     case wasm::kExprS32x4Select:
       return graph()->NewNode(jsgraph()->machine()->S32x4Select(), inputs[0],
                               inputs[1], inputs[2]);
-    case wasm::kExprS16x8ZipLeft:
-      return graph()->NewNode(jsgraph()->machine()->S16x8ZipLeft(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS16x8ZipRight:
-      return graph()->NewNode(jsgraph()->machine()->S16x8ZipRight(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS16x8UnzipLeft:
-      return graph()->NewNode(jsgraph()->machine()->S16x8UnzipLeft(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS16x8UnzipRight:
-      return graph()->NewNode(jsgraph()->machine()->S16x8UnzipRight(),
-                              inputs[0], inputs[1]);
-    case wasm::kExprS16x8TransposeLeft:
-      return graph()->NewNode(jsgraph()->machine()->S16x8TransposeLeft(),
-                              inputs[0], inputs[1]);
-    case wasm::kExprS16x8TransposeRight:
-      return graph()->NewNode(jsgraph()->machine()->S16x8TransposeRight(),
-                              inputs[0], inputs[1]);
     case wasm::kExprS16x8Select:
       return graph()->NewNode(jsgraph()->machine()->S16x8Select(), inputs[0],
                               inputs[1], inputs[2]);
-    case wasm::kExprS8x16ZipLeft:
-      return graph()->NewNode(jsgraph()->machine()->S8x16ZipLeft(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS8x16ZipRight:
-      return graph()->NewNode(jsgraph()->machine()->S8x16ZipRight(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS8x16UnzipLeft:
-      return graph()->NewNode(jsgraph()->machine()->S8x16UnzipLeft(), inputs[0],
-                              inputs[1]);
-    case wasm::kExprS8x16UnzipRight:
-      return graph()->NewNode(jsgraph()->machine()->S8x16UnzipRight(),
-                              inputs[0], inputs[1]);
-    case wasm::kExprS8x16TransposeLeft:
-      return graph()->NewNode(jsgraph()->machine()->S8x16TransposeLeft(),
-                              inputs[0], inputs[1]);
-    case wasm::kExprS8x16TransposeRight:
-      return graph()->NewNode(jsgraph()->machine()->S8x16TransposeRight(),
-                              inputs[0], inputs[1]);
     case wasm::kExprS8x16Select:
       return graph()->NewNode(jsgraph()->machine()->S8x16Select(), inputs[0],
                               inputs[1], inputs[2]);
-    case wasm::kExprS32x2Reverse:
-      return graph()->NewNode(jsgraph()->machine()->S32x2Reverse(), inputs[0]);
-    case wasm::kExprS16x4Reverse:
-      return graph()->NewNode(jsgraph()->machine()->S16x4Reverse(), inputs[0]);
-    case wasm::kExprS16x2Reverse:
-      return graph()->NewNode(jsgraph()->machine()->S16x2Reverse(), inputs[0]);
-    case wasm::kExprS8x8Reverse:
-      return graph()->NewNode(jsgraph()->machine()->S8x8Reverse(), inputs[0]);
-    case wasm::kExprS8x4Reverse:
-      return graph()->NewNode(jsgraph()->machine()->S8x4Reverse(), inputs[0]);
-    case wasm::kExprS8x2Reverse:
-      return graph()->NewNode(jsgraph()->machine()->S8x2Reverse(), inputs[0]);
     case wasm::kExprS1x4And:
       return graph()->NewNode(jsgraph()->machine()->S1x4And(), inputs[0],
                               inputs[1]);
     case wasm::kExprS1x4Or:
       return graph()->NewNode(jsgraph()->machine()->S1x4Or(), inputs[0],
                               inputs[1]);
     case wasm::kExprS1x4Xor:
       return graph()->NewNode(jsgraph()->machine()->S1x4Xor(), inputs[0],
                               inputs[1]);
     case wasm::kExprS1x4Not:
@@ skipping 96 matching lines @@
       return graph()->NewNode(jsgraph()->machine()->I8x16ShrS(shift),
                               inputs[0]);
     case wasm::kExprI8x16ShrU:
       return graph()->NewNode(jsgraph()->machine()->I8x16ShrU(shift),
                               inputs[0]);
     default:
       return graph()->NewNode(UnsupportedOpcode(opcode), nullptr);
   }
 }
 
-Node* WasmGraphBuilder::SimdConcatOp(uint8_t bytes, const NodeVector& inputs) {
+Node* WasmGraphBuilder::SimdShuffleOp(uint8_t shuffle[16], unsigned lanes,
+                                      const NodeVector& inputs) {
   has_simd_ = true;
-  return graph()->NewNode(jsgraph()->machine()->S8x16Concat(bytes), inputs[0],
-                          inputs[1]);
+  switch (lanes) {
+    case 4:
+      return graph()->NewNode(jsgraph()->machine()->S32x4Shuffle(shuffle),
+                              inputs[0], inputs[1]);
+    case 8:
+      return graph()->NewNode(jsgraph()->machine()->S16x8Shuffle(shuffle),
+                              inputs[0], inputs[1]);
+    case 16:
+      return graph()->NewNode(jsgraph()->machine()->S8x16Shuffle(shuffle),
+                              inputs[0], inputs[1]);
+    default:
+      UNREACHABLE();
+      return nullptr;
+  }
 }
 
 static void RecordFunctionCompilation(CodeEventListener::LogEventsAndTags tag,
                                       Isolate* isolate, Handle<Code> code,
                                       const char* message, uint32_t index,
                                       const wasm::WasmName& module_name,
                                       const wasm::WasmName& func_name) {
   DCHECK(isolate->logger()->is_logging_code_events() ||
          isolate->is_profiling());
 
@@ skipping 456 matching lines @@
     wasm::ModuleBytesEnv* module_env, const wasm::WasmFunction* function) {
   WasmCompilationUnit unit(isolate, module_env, function);
   unit.InitializeHandles();
   unit.ExecuteCompilation();
   return unit.FinishCompilation(thrower);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8