DescriptionRevert of Reland "[Chromecast] Use base::FeatureList to control features." (patchset #4 id:60001 of https://codereview.chromium.org/2836263003/ )
Reason for revert:
Breaks ATV at runtime.
Original issue's description:
> Reland "[Chromecast] Use base::FeatureList to control features."
>
> This feature was reverted due to the new browsertest being flaky on
> internal Cast infrastructure: crrev.com/2838813003
>
> === Original Commit Message ===
> In Chromium, Finch-enabled features are controlled through base::FeatureList,
> a class which abstracts the experiment framework and developer overrides
> from client code. Though Chromecast's experiment framework is fundamentally
> different (in that it is server-driven) Cast builds can still make use of
> this class. Introduce some utilities to help.
>
> At boot-up, the pref store will be queried for experiment configs, which
> were cached to disk on the most recent config fetch from the last boot
> cycle. If a developer overrides these features from the command line,
> that value takes precedence. These features will be used to initialize
> base::FeatureList, which can then be statically queried from any client
> code that depends on //base.
>
> This patch does not actually introduce or convert any existing features
> to use this framework.
>
> BUG=714291
> BUG= internal b/35424335
>
> Review-Url: https://codereview.chromium.org/2836263003
> Cr-Commit-Position: refs/heads/master@{#467998}
> Committed: https://chromium.googlesource.com/chromium/src/+/aab6bf24d32d931359b2d0c25fb39b3ed51fbc86
TBR=maclellant@chromium.org,halliwell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=714291
Review-Url: https://codereview.chromium.org/2847423002
Cr-Commit-Position: refs/heads/master@{#468249}
Committed: https://chromium.googlesource.com/chromium/src/+/efddbe79f23b2ecbaf250302bd70c4fd82c002dd
Patch Set 1 #
Messages
Total messages: 10 (5 generated)
|