Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4509)

Unified Diff: chrome/browser/extensions/extension_unload_browsertest.cc

Issue 2847313002: Update some host_resolver()->AddRules in chrome/browser. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_unload_browsertest.cc
diff --git a/chrome/browser/extensions/extension_unload_browsertest.cc b/chrome/browser/extensions/extension_unload_browsertest.cc
index f11a57687d872abdb8d68dcd4589918f7e3d0cd3..97e2420d5db30ca10f30a050b344c8776c86a387 100644
--- a/chrome/browser/extensions/extension_unload_browsertest.cc
+++ b/chrome/browser/extensions/extension_unload_browsertest.cc
@@ -14,7 +14,13 @@
namespace extensions {
-using ExtensionUnloadBrowserTest = ExtensionBrowserTest;
+class ExtensionUnloadBrowserTest : public ExtensionBrowserTest {
+ public:
+ void SetUpOnMainThread() override {
+ ExtensionBrowserTest::SetUpOnMainThread();
+ host_resolver()->AddRule("maps.google.com", "127.0.0.1");
+ }
+};
IN_PROC_BROWSER_TEST_F(ExtensionUnloadBrowserTest, TestUnload) {
// Load an extension that installs unload and beforeunload listeners.
@@ -41,7 +47,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionUnloadBrowserTest, TestUnload) {
// After an extension is uninstalled, network requests from its content scripts
// should fail but not kill the renderer process.
IN_PROC_BROWSER_TEST_F(ExtensionUnloadBrowserTest, UnloadWithContentScripts) {
- host_resolver()->AddRule("maps.google.com", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->Start());
// Load an extension with a content script that has a button to send XHRs.

Powered by Google App Engine
This is Rietveld 408576698