Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: chrome/browser/extensions/extension_javascript_url_apitest.cc

Issue 2847313002: Update some host_resolver()->AddRules in chrome/browser. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_javascript_url_apitest.cc
diff --git a/chrome/browser/extensions/extension_javascript_url_apitest.cc b/chrome/browser/extensions/extension_javascript_url_apitest.cc
index 358f550a11025396454d8603b8607fd0e7aa865f..bac248f665b20ea28079086a33e03a527142baad 100644
--- a/chrome/browser/extensions/extension_javascript_url_apitest.cc
+++ b/chrome/browser/extensions/extension_javascript_url_apitest.cc
@@ -5,18 +5,20 @@
#include "chrome/browser/extensions/extension_apitest.h"
#include "net/dns/mock_host_resolver.h"
-// If crashing, mark disabled and update http://crbug.com/63589.
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, JavaScriptURLPermissions) {
- host_resolver()->AddRule("a.com", "127.0.0.1");
- host_resolver()->AddRule("b.com", "127.0.0.1");
- ASSERT_TRUE(StartEmbeddedTestServer());
+class JavscriptApiTest : public ExtensionApiTest {
+ public:
+ void SetUpOnMainThread() override {
+ ExtensionApiTest::SetUpOnMainThread();
+ host_resolver()->AddRule("*", "127.0.0.1");
+ ASSERT_TRUE(StartEmbeddedTestServer());
+ }
+};
+// If crashing, mark disabled and update http://crbug.com/63589.
+IN_PROC_BROWSER_TEST_F(JavscriptApiTest, JavaScriptURLPermissions) {
ASSERT_TRUE(RunExtensionTest("tabs/javascript_url_permissions")) << message_;
}
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, JavasScriptEncodedURL) {
- host_resolver()->AddRule("a.com", "127.0.0.1");
- ASSERT_TRUE(StartEmbeddedTestServer());
-
+IN_PROC_BROWSER_TEST_F(JavscriptApiTest, JavasScriptEncodedURL) {
ASSERT_TRUE(RunExtensionTest("tabs/javascript_url_encoded")) << message_;
}
« no previous file with comments | « chrome/browser/extensions/extension_incognito_apitest.cc ('k') | chrome/browser/extensions/extension_messages_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698