Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/extensions/chrome_app_api_browsertest.cc

Issue 2847313002: Update some host_resolver()->AddRules in chrome/browser. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_app_api_browsertest.cc
diff --git a/chrome/browser/extensions/chrome_app_api_browsertest.cc b/chrome/browser/extensions/chrome_app_api_browsertest.cc
index 8bbc52e43986bdab2dfee9060248ed268d9efb91..2c2340446c89640e3339ea72e79dda5d41b5e666 100644
--- a/chrome/browser/extensions/chrome_app_api_browsertest.cc
+++ b/chrome/browser/extensions/chrome_app_api_browsertest.cc
@@ -26,6 +26,12 @@
using extensions::Extension;
class ChromeAppAPITest : public ExtensionBrowserTest {
+ void SetUpOnMainThread() override {
+ ExtensionBrowserTest::SetUpOnMainThread();
+ host_resolver()->AddRule("*", "127.0.0.1");
+ ASSERT_TRUE(embedded_test_server()->Start());
+ }
+
protected:
bool IsAppInstalledInMainFrame() {
return IsAppInstalledInFrame(
@@ -89,8 +95,6 @@ class ChromeAppAPITest : public ExtensionBrowserTest {
};
IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) {
- host_resolver()->AddRule("*", "127.0.0.1");
- ASSERT_TRUE(embedded_test_server()->Start());
GURL app_url =
embedded_test_server()->GetURL("app.com", "/extensions/test_file.html");
GURL non_app_url = embedded_test_server()->GetURL(
@@ -168,8 +172,6 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) {
}
IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, InstallAndRunningState) {
- host_resolver()->AddRule("*", "127.0.0.1");
- ASSERT_TRUE(embedded_test_server()->Start());
GURL app_url = embedded_test_server()->GetURL(
"app.com", "/extensions/get_app_details_for_frame.html");
GURL non_app_url = embedded_test_server()->GetURL(
@@ -225,8 +227,6 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, InstallAndRunningState) {
}
IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, InstallAndRunningStateFrame) {
- host_resolver()->AddRule("*", "127.0.0.1");
- ASSERT_TRUE(embedded_test_server()->Start());
GURL app_url = embedded_test_server()->GetURL(
"app.com", "/extensions/get_app_details_for_frame_reversed.html");
« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | chrome/browser/extensions/content_capabilities_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698