Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2847173003: cros: Update virtual audio label name to Built-in mic/speaker (Closed)

Created:
3 years, 7 months ago by Qiang(Joe) Xu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Update virtual audio label name to Built-in mic/speaker Changes: As from discussion with UX writer, updating the label name here. BUG=658048 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2847173003 Cr-Commit-Position: refs/heads/master@{#468248} Committed: https://chromium.googlesource.com/chromium/src/+/934e8926ee432fe5f5e6b2b9a1f196455ede77df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/audio/cras/audio_manager_cras.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Qiang(Joe) Xu
Hi tommi@, ptal, thanks. As for "recommend including notes for localization as other languages might ...
3 years, 7 months ago (2017-04-29 00:33:28 UTC) #4
tommi (sloooow) - chröme
lgtm
3 years, 7 months ago (2017-04-29 12:03:06 UTC) #5
tommi (sloooow) - chröme
On 2017/04/29 00:33:28, Qiang(Joe) Xu wrote: > Hi tommi@, ptal, thanks. As for "recommend including ...
3 years, 7 months ago (2017-04-29 12:05:53 UTC) #6
Qiang(Joe) Xu
On 2017/04/29 12:05:53, tommi - chröme wrote: > On 2017/04/29 00:33:28, Qiang(Joe) Xu wrote: > ...
3 years, 7 months ago (2017-04-29 18:25:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847173003/1
3 years, 7 months ago (2017-04-29 18:26:17 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 20:13:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/934e8926ee432fe5f5e6b2b9a1f1...

Powered by Google App Engine
This is Rietveld 408576698