Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2846183002: Add the new icon for the new translate infobar. (Closed)

Created:
3 years, 7 months ago by Marti Wong
Modified:
3 years, 7 months ago
Reviewers:
Leo, gone
CC:
chromium-reviews, dfalcantara+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the new icon for the new translate infobar. The new icon is used in the new infobar only. The icon in the old translate infobar and "main menu -> settings -> site settings" will remain unchanged at the moment. BUG=703887 Review-Url: https://codereview.chromium.org/2846183002 Cr-Commit-Position: refs/heads/master@{#468576} Committed: https://chromium.googlesource.com/chromium/src/+/e588d5c7e3c93b48d11312ea90be5d0ba23193f0

Patch Set 1 #

Patch Set 2 : remove the hack code #

Patch Set 3 : Synched & optimized pngs #

Messages

Total messages: 13 (7 generated)
Marti Wong
Hi Dan, PTAL. Do I need somebody else to approve the new drawable png? thanks!
3 years, 7 months ago (2017-04-28 06:48:51 UTC) #5
gone
Have you run tools/resources/optimize-png-files.sh on these?
3 years, 7 months ago (2017-04-30 02:04:23 UTC) #6
Marti Wong
On 2017/04/30 02:04:23, slow (dfalcantara) wrote: > Have you run tools/resources/optimize-png-files.sh on these? Thanks for ...
3 years, 7 months ago (2017-05-02 06:08:13 UTC) #7
gone
lgtm
3 years, 7 months ago (2017-05-02 06:09:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846183002/40001
3 years, 7 months ago (2017-05-02 06:11:48 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 06:58:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e588d5c7e3c93b48d11312ea90be...

Powered by Google App Engine
This is Rietveld 408576698