Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2845023002: [lint] Fix lint to not raise an exception at the end. (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[lint] Fix lint to not raise an exception at the end. Also whitelist 'ast', which is harmless and used in some repos. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2845023002 Committed: https://github.com/luci/recipes-py/commit/11737a0978310326dcf0607c7532ade24f696c3d

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M recipe_engine/lint_test.py View 3 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
iannucci
3 years, 7 months ago (2017-04-27 07:45:42 UTC) #1
dnj
lgtm
3 years, 7 months ago (2017-04-27 17:21:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845023002/20001
3 years, 7 months ago (2017-04-29 19:43:49 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 19:46:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/11737a0978310326dcf0607c7532ade24f6...

Powered by Google App Engine
This is Rietveld 408576698