ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm - Issue 2844253003: Adding close button in SigninPromoView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm

Issue 2844253003: Adding close button in SigninPromoView (Closed)

Patch Set: Changing dismiss to close, and moving the button to the cell Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm

diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm b/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm

index 8234110a7dddfbe14153bf4970c2107b99e58c6f..40d298aceb879c3a12852a1b869e92ac1d887f6f 100644

--- a/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm

+++ b/ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm

@@ -414,6 +414,10 @@ CGSize PreferredCellSizeForWidth(UICollectionViewCell* cell, CGFloat width) {

signinPromoCell.signinPromoView.sendChromeCommand = YES;

[[_signinPromoViewMediator createConfigurator]

configureSigninPromoView:signinPromoCell.signinPromoView];

+ __weak BookmarkFolderCollectionView* weakSelf = self;

+ signinPromoCell.closeButtonAction = ^() {

+ [weakSelf.delegate bookmarkCollectionViewDismissPromo:self];

+ };

return signinPromoCell;

} else {

BookmarkPromoCell* promoCell = [self.collectionView