Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2839663003: Replace ASSERT with DHCECK_op in platform/wtf (Closed)

Created:
3 years, 8 months ago by Hwanseung Lee
Modified:
3 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT with DHCECK_op in platform/wtf Replace ASSERT with DCHECK_op respectively in third_party/WebKit/Source/platform/wtf BUG=707661 Review-Url: https://codereview.chromium.org/2839663003 Cr-Commit-Position: refs/heads/master@{#470188} Committed: https://chromium.googlesource.com/chromium/src/+/0cf75135e125604870a9eb91e4178ba18398d8f3

Patch Set 1 #

Patch Set 2 : wtf #

Total comments: 4

Patch Set 3 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -110 lines) Patch
M third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc View 1 2 17 chunks +24 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc View 1 11 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/cached-powers.cc View 1 4 chunks +14 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.cc View 1 13 chunks +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/fast-dtoa.cc View 1 12 chunks +30 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc View 9 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 41 (34 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 7 months ago (2017-05-08 12:13:12 UTC) #29
tkent
lgtm https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc File third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc (right): https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc#newcode492 third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc:492: DCHECK(IsClamped()); You shouldn't change indentation. However, if this ...
3 years, 7 months ago (2017-05-08 14:31:04 UTC) #30
Hwanseung Lee
https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc File third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc (right): https://codereview.chromium.org/2839663003/diff/60001/third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc#newcode492 third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc:492: DCHECK(IsClamped()); On 2017/05/08 14:31:03, tkent wrote: > You shouldn't ...
3 years, 7 months ago (2017-05-08 23:31:13 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839663003/80001
3 years, 7 months ago (2017-05-08 23:35:59 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, build has not started yet; ...
3 years, 7 months ago (2017-05-09 01:21:32 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839663003/80001
3 years, 7 months ago (2017-05-09 01:25:57 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:12:58 UTC) #41
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0cf75135e125604870a9eb91e417...

Powered by Google App Engine
This is Rietveld 408576698