Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3853)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2838833003: Introduces snackbar enum, & other snackbar classes on android for translate (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateSnackbarController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index 272f5777a53f6659f16eaf261d6503264cec03da..b9a5a8f77a74072e95ac9d17619dc133e9c12db5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -141,14 +141,17 @@ class TranslateCompactInfoBar extends InfoBar
case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:
nativeApplyBoolTranslateOption(
mNativeTranslateInfoBarPtr, TranslateOption.ALWAYS_TRANSLATE, true);
+ showSnackbar(TranslateSnackbarType.ALWAYS_TRANSLATE);
return;
case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:
nativeApplyBoolTranslateOption(
mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE, true);
+ showSnackbar(TranslateSnackbarType.NEVER_TRANSLATE);
return;
case TranslateMenu.ID_OVERFLOW_NEVER_SITE:
nativeApplyBoolTranslateOption(
mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE_SITE, true);
+ showSnackbar(TranslateSnackbarType.NEVER_TRANSLATE_SITE);
return;
case TranslateMenu.ID_OVERFLOW_NOT_THIS_LANGUAGE:
mMenuHelper.show(TranslateMenu.MENU_SOURCE_LANGUAGE);
@@ -158,6 +161,10 @@ class TranslateCompactInfoBar extends InfoBar
}
}
+ private void showSnackbar(int snackbarType) {
+ // TODO(ramyasharma): Show snackbar.
+ }
+
@Override
public void onTargetMenuItemClicked(String code) {
// Reset target code in both UI and native.
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateSnackbarController.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698