Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 283833006: DevTools: Fix content_shell devtools built in debug_devtools=1 mode (Closed)

Created:
6 years, 7 months ago by apavlov
Modified:
6 years, 7 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix content_shell devtools built in debug_devtools=1 mode This has never worked properly, as content_shell uses both raw (non-concatenated) JS resources and a grd-based resource bundle. As a side effect, the flattening of build-copied resources (effectively, cm/*.css only) and the buildSystemOnly.js file have been eliminated. R=pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174145

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Address comment #

Patch Set 4 : Fix codemirror CSS copying in debug_devtools=0 mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -56 lines) Patch
M Source/devtools/devtools.gyp View 1 2 3 8 chunks +25 lines, -26 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 3 chunks +30 lines, -4 lines 0 comments Download
D Source/devtools/front_end/buildSystemOnly.js View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/View.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/scripts/generate_devtools_grd.py View 1 3 chunks +11 lines, -11 lines 0 comments Download
M Source/devtools/scripts/generate_devtools_html.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
apavlov
6 years, 7 months ago (2014-05-14 15:49:02 UTC) #1
vsevik
lgtm It would be great if we used grd for chrome with debug_devtools flag set ...
6 years, 7 months ago (2014-05-15 13:57:47 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 7 months ago (2014-05-15 14:13:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/283833006/40001
6 years, 7 months ago (2014-05-15 14:13:48 UTC) #4
apavlov
https://chromiumcodereview.appspot.com/283833006/diff/20001/Source/devtools/devtools.gyp File Source/devtools/devtools.gyp (right): https://chromiumcodereview.appspot.com/283833006/diff/20001/Source/devtools/devtools.gyp#newcode173 Source/devtools/devtools.gyp:173: '<(PRODUCT_DIR)/resources/inspector', On 2014/05/15 13:57:47, vsevik wrote: > Consider adding ...
6 years, 7 months ago (2014-05-15 14:25:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 15:49:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 16:33:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7287) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6793)
6 years, 7 months ago (2014-05-15 16:33:57 UTC) #8
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 7 months ago (2014-05-16 07:39:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/283833006/60001
6 years, 7 months ago (2014-05-16 07:40:05 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 08:55:39 UTC) #11
Message was sent while issue was closed.
Change committed as 174145

Powered by Google App Engine
This is Rietveld 408576698