Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: ui/accessibility/platform/ax_platform_node_win.cc

Issue 2833843005: Handling of different types of empty alt (Closed)
Patch Set: Ready to land Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/accessibility/ax_enums.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/platform/ax_platform_node_win.cc
diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc
index 2845822fcce5a925c14e097f06ea5a8ec4a5a2ca..239a2a654102795923ac6b6dff0d13067e187c96 100644
--- a/ui/accessibility/platform/ax_platform_node_win.cc
+++ b/ui/accessibility/platform/ax_platform_node_win.cc
@@ -484,6 +484,7 @@ STDMETHODIMP AXPlatformNodeWin::get_accName(
*name = SysAllocString(str.c_str());
DCHECK(*name);
}
+
return result;
}
@@ -1207,9 +1208,6 @@ HRESULT AXPlatformNodeWin::GetStringAttributeAsBstr(
if (!GetString16Attribute(attribute, &str))
return S_FALSE;
- if (str.empty())
- return S_FALSE;
-
*value_bstr = SysAllocString(str.c_str());
DCHECK(*value_bstr);
« no previous file with comments | « ui/accessibility/ax_enums.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698