content/browser/accessibility/browser_accessibility_android.cc - Issue 2833843005: Handling of different types of empty alt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 2833843005: Handling of different types of empty alt (Closed)

Patch Set: Ready to land Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index 52d65365a84a931632cde9c0ca2676e0aadd7ccc..8028085036e6dae75f7e02b7a38457ee83836385 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -408,7 +408,8 @@ base::string16 BrowserAccessibilityAndroid::GetText() const {

}

- if (text.empty() && (IsLink() || GetRole() == ui::AX_ROLE_IMAGE)) {

+ if (text.empty() && (IsLink() || GetRole() == ui::AX_ROLE_IMAGE) &&

+ !HasExplicitlyEmptyName()) {

base::string16 url = GetString16Attribute(ui::AX_ATTR_URL);

text = ui::AXSnapshotNodeAndroid::AXUrlBaseText(url);

}