Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2401)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Issue 2833673003: 🔍 More consistent first run triggering (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
index 069cd9aa3039e91456179a70016f6932f7bd824e..157f133b62f694b8d4e589a675133e742bc8fa69 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
@@ -167,7 +167,11 @@ public class FirstRunActivity extends AsyncInitializationActivity implements Fir
mPostNativePageSequenceCreated = true;
}
- // AsyncInitializationActivity:
+ @Override
+ protected boolean requiresFirstRunToBeCompleted(Intent intent) {
+ // The user is already in First Run.
+ return false;
+ }
@Override
protected Bundle transformSavedInstanceStateForOnCreate(Bundle savedInstanceState) {
@@ -598,4 +602,10 @@ public class FirstRunActivity extends AsyncInitializationActivity implements Fir
public void showInfoPage(int url) {
CustomTabActivity.showInfoPage(this, getString(url));
}
+
+ /** Returns whether or not First Run is ready for interaction. */
+ @VisibleForTesting
+ public boolean isPostNativePageSequenceCreated() {
+ return mPostNativePageSequenceCreated;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698