Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: ash/system/tray/tray_popup_utils.h

Issue 2831023003: Refactor AddScrollListItem() in system menu detailed views (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/tray_details_view_unittest.cc ('k') | ash/system/tray/tray_popup_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/tray_popup_utils.h
diff --git a/ash/system/tray/tray_popup_utils.h b/ash/system/tray/tray_popup_utils.h
index d674034c8b8e9384d5e47dcfcc3440aa56f77191..db2686935efc6c2d2af82effffa3822de60d19e2 100644
--- a/ash/system/tray/tray_popup_utils.h
+++ b/ash/system/tray/tray_popup_utils.h
@@ -54,13 +54,18 @@ class TrayPopupUtils {
// Creates a container view to be used by system menu sub-section header rows.
// The caller takes over ownership of the created view.
//
- // The returned view consists of 2 regions: CENTER, and END having the same
- // properties as when using |CreateMultiTargetRowView|. The START container is
- // hidden.
- // The END container has a fixed minimum width but can grow into the CENTER
- // container if space is required and available. The CENTER container has a
- // flexible width.
- static TriView* CreateSubHeaderRowView();
+ // The returned view contains at least CENTER and END regions having the same
+ // properties as when using |CreateMultiTargetRowView|. |start_visible|
+ // determines whether the START region should be visible or not. If START is
+ // not visible, extra padding is added to the left of the contents.
+ //
+ // The START (if visible) and END containers have a fixed minimum width but
+ // can grow into the CENTER container if space is required and available. The
+ // CENTER container has a flexible width.
+ //
+ // TODO(mohsen): Merge this into TrayDetailsView::AddScrollListSubHeader()
+ // once network and VPN alse use TrayDetailsView::AddScrollListSubHeader().
+ static TriView* CreateSubHeaderRowView(bool start_visible);
// Creates a view containing only a label (corresponding to |message_id|),
// which is to be inserted as a non-targetable row within a system menu
« no previous file with comments | « ash/system/tray/tray_details_view_unittest.cc ('k') | ash/system/tray/tray_popup_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698