Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: ash/system/tray/hover_highlight_view.cc

Issue 2831023003: Refactor AddScrollListItem() in system menu detailed views (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/hover_highlight_view.h ('k') | ash/system/tray/tray_details_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/hover_highlight_view.cc
diff --git a/ash/system/tray/hover_highlight_view.cc b/ash/system/tray/hover_highlight_view.cc
index c3f7cfa37c159b7b20ac4127aec38643b7f37a6e..e96272b6761e84dc7390fca4249f3bf68588ab77 100644
--- a/ash/system/tray/hover_highlight_view.cc
+++ b/ash/system/tray/hover_highlight_view.cc
@@ -55,6 +55,19 @@ void HoverHighlightView::SetRightViewVisible(bool visible) {
Layout();
}
+void HoverHighlightView::SetSubText(const base::string16& sub_text) {
+ DCHECK(text_label_);
+
+ if (!sub_text_label_) {
+ sub_text_label_ = TrayPopupUtils::CreateDefaultLabel();
+ tri_view_->AddView(TriView::Container::CENTER, sub_text_label_);
+ }
+ TrayPopupItemStyle sub_style(TrayPopupItemStyle::FontStyle::CAPTION);
+ sub_style.set_color_style(TrayPopupItemStyle::ColorStyle::INACTIVE);
+ sub_style.SetupLabel(sub_text_label_);
+ sub_text_label_->SetText(sub_text);
+}
+
void HoverHighlightView::AddIconAndLabel(const gfx::ImageSkia& image,
const base::string16& text) {
DoAddIconAndLabel(image, text,
@@ -102,16 +115,9 @@ void HoverHighlightView::DoAddIconAndLabels(
text_label_->SetEnabled(enabled());
TrayPopupItemStyle style(font_style);
style.SetupLabel(text_label_);
-
tri_view_->AddView(TriView::Container::CENTER, text_label_);
- if (!sub_text.empty()) {
- sub_text_label_ = TrayPopupUtils::CreateDefaultLabel();
- sub_text_label_->SetText(sub_text);
- TrayPopupItemStyle sub_style(TrayPopupItemStyle::FontStyle::CAPTION);
- sub_style.set_color_style(TrayPopupItemStyle::ColorStyle::INACTIVE);
- sub_style.SetupLabel(sub_text_label_);
- tri_view_->AddView(TriView::Container::CENTER, sub_text_label_);
- }
+
+ SetSubText(sub_text);
tri_view_->SetContainerVisible(TriView::Container::END, false);
« no previous file with comments | « ash/system/tray/hover_highlight_view.h ('k') | ash/system/tray/tray_details_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698