net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/android/java/src/org/chromium/net/NetworkChangeNotifier.java ('k') | remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java

diff --git a/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java b/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java

index e1da29a3e4bd92b10d7961087935ecc9840afe0f..6603ad2da91013f98439ce4b38ec65758331e933 100644

--- a/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java

+++ b/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java

@@ -350,6 +350,7 @@ public class NetworkChangeNotifierAutoDetect extends BroadcastReceiver {

// Lazily determine if app has ACCESS_WIFI_STATE permission.

@GuardedBy("mLock")

+ @SuppressLint("WifiManagerPotentialLeak")

private boolean hasPermissionLocked() {

if (mHasWifiPermissionComputed) {

return mHasWifiPermission;

@@ -357,6 +358,7 @@ public class NetworkChangeNotifierAutoDetect extends BroadcastReceiver {

mHasWifiPermission = mContext.getPackageManager().checkPermission(

permission.ACCESS_WIFI_STATE, mContext.getPackageName())

== PackageManager.PERMISSION_GRANTED;

+ // TODO(crbug.com/635567): Fix lint properly.

mWifiManager = mHasWifiPermission

? (WifiManager) mContext.getSystemService(Context.WIFI_SERVICE)

: null;