content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java - Issue 2830843004: Update to newer Android Lint and suppress new Lint errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java ('k') | device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

index 0d55839034b89594d4f246f53cf11350d8e283f7..b1c338393f03c77a454f476092a44a9a0d338659 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

@@ -4,6 +4,7 @@

package org.chromium.content.browser;

+import android.annotation.SuppressLint;

import android.content.Context;

import android.os.Bundle;

import android.os.IBinder;

@@ -190,6 +191,7 @@ public class ChildProcessLauncher {

// This is used for a child process allocation to determine if StartCallback should be chained.

// |sSpareConnectionStartCallback| is the chained StartCallback. This is also used to determine

// if there is already a child process launch that's used this this connection.

+ @SuppressLint("StaticFieldLeak")

private static BaseChildProcessConnection sSpareSandboxedConnection;

private static boolean sSpareConnectionStarting;

private static BaseChildProcessConnection.StartCallback sSpareConnectionStartCallback;