Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/services/GoogleServicesManager.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.services; 5 package org.chromium.chrome.browser.services;
6 6
7 import android.annotation.SuppressLint;
7 import android.content.Context; 8 import android.content.Context;
8 import android.util.Log; 9 import android.util.Log;
9 10
10 import org.chromium.base.ApplicationState; 11 import org.chromium.base.ApplicationState;
11 import org.chromium.base.ApplicationStatus; 12 import org.chromium.base.ApplicationStatus;
12 import org.chromium.base.ApplicationStatus.ApplicationStateListener; 13 import org.chromium.base.ApplicationStatus.ApplicationStateListener;
13 import org.chromium.base.ThreadUtils; 14 import org.chromium.base.ThreadUtils;
14 import org.chromium.base.TraceEvent; 15 import org.chromium.base.TraceEvent;
15 import org.chromium.base.VisibleForTesting; 16 import org.chromium.base.VisibleForTesting;
16 import org.chromium.chrome.browser.signin.SigninHelper; 17 import org.chromium.chrome.browser.signin.SigninHelper;
(...skipping 13 matching lines...) Expand all
30 * The object must be created on the main thread. 31 * The object must be created on the main thread.
31 * <p/> 32 * <p/>
32 */ 33 */
33 public class GoogleServicesManager implements ApplicationStateListener { 34 public class GoogleServicesManager implements ApplicationStateListener {
34 35
35 private static final String TAG = "GoogleServicesManager"; 36 private static final String TAG = "GoogleServicesManager";
36 37
37 @VisibleForTesting 38 @VisibleForTesting
38 public static final String SESSION_TAG_PREFIX = "session_sync"; 39 public static final String SESSION_TAG_PREFIX = "session_sync";
39 40
41 @SuppressLint("StaticFieldLeak")
40 private static GoogleServicesManager sGoogleServicesManager; 42 private static GoogleServicesManager sGoogleServicesManager;
41 43
42 @VisibleForTesting 44 @VisibleForTesting
43 protected final Context mContext; 45 protected final Context mContext;
44 46
45 private final ChromeSigninController mChromeSigninController; 47 private final ChromeSigninController mChromeSigninController;
46 48
47 private final SigninHelper mSigninHelper; 49 private final SigninHelper mSigninHelper;
48 50
49 /** 51 /**
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 } 110 }
109 } 111 }
110 112
111 @Override 113 @Override
112 public void onApplicationStateChange(int newState) { 114 public void onApplicationStateChange(int newState) {
113 if (newState == ApplicationState.HAS_RUNNING_ACTIVITIES) { 115 if (newState == ApplicationState.HAS_RUNNING_ACTIVITIES) {
114 onMainActivityStart(); 116 onMainActivityStart();
115 } 117 }
116 } 118 }
117 } 119 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698